Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ReflectionNamedType::getClass() #836

Merged
merged 2 commits into from
Nov 7, 2021
Merged

Added ReflectionNamedType::getClass() #836

merged 2 commits into from
Nov 7, 2021

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Nov 6, 2021

No description provided.

@kukulich kukulich mentioned this pull request Nov 6, 2021
Merged
7 tasks
@kukulich kukulich marked this pull request as ready for review November 6, 2021 09:49
@kukulich kukulich marked this pull request as draft November 6, 2021 10:09
@kukulich kukulich force-pushed the get-class branch 2 times, most recently from 7c7ac0b to af0ea19 Compare November 6, 2021 16:00
Ocramius
Ocramius approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, excellent work as usual, @kukulich!

My comments are only around understanding (requiring some documentation additions), as well as potential refactoring for readability

src/Reflection/ReflectionClass.php Show resolved Hide resolved
src/Reflection/ReflectionFunctionAbstract.php Show resolved Hide resolved
src/Reflection/ReflectionMethod.php Show resolved Hide resolved
src/Reflection/ReflectionNamedType.php Outdated Show resolved Hide resolved
src/Reflection/ReflectionParameter.php Show resolved Hide resolved
@Ocramius Ocramius added this to the 5.0.0 milestone Nov 6, 2021
@Ocramius
Copy link
Member

Ocramius commented Nov 6, 2021

Also, thank you so much for helping out with the progress on Roave/BackwardCompatibilityCheck#324 through this patch!

I'm much slower than you at jumping at all this stuff :D

@kukulich kukulich marked this pull request as ready for review November 6, 2021 23:32
Ocramius
Ocramius approved these changes Nov 7, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Thanks @kukulich!

@Ocramius Ocramius changed the title Added ReflectionNamedType::getClass() Added ReflectionNamedType::getClass() Nov 7, 2021
@Ocramius Ocramius merged commit e52cbda into Roave:5.0.x Nov 7, 2021
@kukulich kukulich deleted the get-class branch November 7, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kukulich @Ocramius