Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make existing tests / static analysis pass on PHP 8.0.x #750

Merged
merged 27 commits into from
Sep 16, 2021
Merged

Make existing tests / static analysis pass on PHP 8.0.x #750

merged 27 commits into from
Sep 16, 2021

Conversation

kukulich
Copy link
Collaborator

@kukulich kukulich commented Sep 8, 2021

It's not perfect, it's just start so it's possible to do more PR :)

@kukulich kukulich changed the title Update some depenciens Update some dependencies Sep 8, 2021
@Ocramius
Copy link
Member

Ocramius commented Sep 8, 2021

I think you need a config.platform.php: 7.4.99 in composer.json for this to work, for now: that will install dependencies that are compatible with 7.4 as we work with CI upgrades 🤔

@asgrim asgrim added this to the 4.13.0 milestone Sep 9, 2021
@kukulich kukulich marked this pull request as draft September 9, 2021 07:13
@kukulich
Copy link
Collaborator Author

kukulich commented Sep 9, 2021

Converted to draft. I'll try to make it PHP 8 only and better :)

@kukulich kukulich mentioned this pull request Sep 9, 2021
Closed
13 tasks
@kukulich kukulich force-pushed the php8 branch 3 times, most recently from a992893 to 1b5dbd0 Compare September 10, 2021 11:56
@kukulich kukulich changed the title Update some dependencies PHP 8 start Sep 10, 2021
@WyriHaximus WyriHaximus mentioned this pull request Sep 13, 2021
Merged
@kukulich kukulich force-pushed the php8 branch 13 times, most recently from a277a58 to 2e81739 Compare September 13, 2021 21:49
@kukulich kukulich force-pushed the php8 branch 2 times, most recently from 4af9118 to 7d1f98c Compare September 14, 2021 08:16
@kukulich
Copy link
Collaborator Author

@Ocramius I've just removed two @WyriHaximus's commits and build should be green in 30 minutes.

@kukulich
Copy link
Collaborator Author

All green :)

@Ocramius
Copy link
Member

Let's roll with this as-is for now then :)

Ocramius
Ocramius approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius merged commit 738f67b into Roave:5.0.x Sep 16, 2021
@Ocramius
Copy link
Member

Thanks @kukulich!

This was referenced Sep 17, 2021
Closed
Closed
Closed
@kukulich kukulich deleted the php8 branch September 17, 2021 07:20
@kukulich kukulich mentioned this pull request Sep 17, 2021
Closed
@Ocramius Ocramius linked an issue Sep 17, 2021 that may be closed by this pull request
ReflectionClass:getConstants() signature has changed in PHP 8 #679
Closed
@kukulich kukulich mentioned this pull request Sep 20, 2021
Merged
@aurimasniekis aurimasniekis mentioned this pull request Jan 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes left review comments

@WyriHaximus WyriHaximus WyriHaximus left review comments

@Ocramius Ocramius Ocramius approved these changes

Assignees

@WyriHaximus WyriHaximus

@Ocramius Ocramius

@kukulich kukulich

Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

ReflectionClass:getConstants() signature has changed in PHP 8
5 participants
@kukulich @Ocramius @WyriHaximus @ondrejmirtes @asgrim