Upgrade to support PHP 8.4 runtime and basic code parsing (not the hooks hell of PHP 8.4) #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
commented
Jan 27, 2025
1 task
|
#741 may solve this, btw |
| datasource | package | from | to | | ---------- | ---------------- | ------ | ----- | | packagist | nikic/php-parser | 4.19.4 | 5.4.0 |
* instructed `psalm/plugin-phpunit` to ignore unused `test/` code * instructed PHPUnit to convert deprecations to failures (new XSD) * moved to newer Psalm / PHP-Parser versions * moved to PHPUnit attributes for coverage and data providers * migrated to new PHPUnit source directory declarations Note: some `./vendor/bin/psalm` commands fail when caching is involved: usages of some methods seem to not be picked up properly.
3e86aa6 to
2870fa0
Compare
This should give us PHP 8.4.1 or newer
Some dependencies currently raise deprecation warnings there: * `shish/safe:2.6.0` (`2.6.4` was released) * `beberlei/assert:3.3.0` (`3.3.3` was released) Adding a `conflict` clause is viable, but way too aggressive, and propagates through the dependency graph here. The package works with these, but with deprecations.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs:
merge Remove(workaround found)phpdbg, migrate topcovlaminas/laminas-continuous-integration-action#130 first