-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8 support #283
Comments
I think BR (which this depends on) already supports PHP 8, but yeah the named params BC break is a big one that will need to go in. Sorry kinda dropped the ball there :/ (#266 is the PR I opened, it is incomplete at the moment) |
BetterReflection needs major work: Roave/BetterReflection#701 |
clearly this is fake news |
Any update on this? Thanks! |
@sebastianbergmann no work happening here ATM - too much stuff to maintain, and too little time to get it done. Roave/BetterReflection#701 is still the major issue here. |
If you're pushy, you can try to just run it. Mind the installer output the configured PHP version has all the extensions, the warnings for the PHP versions I did ignore and it all worked. Replace :dev-master or any of the composer config options in the composer related goals to control with which version you would like to run. Display is optimized for composer 2, log has all standard error, standard output is unfiltered. https://gist.github.com/ktomk/30149eec13fa6ed7374cdae5d2ef86f9 |
Just beware that it will crash and/or misreport on the first usages of PHP
8 built-ins.
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
…On Wed, Jun 2, 2021 at 6:01 PM Tom Klingenberg ***@***.***> wrote:
If you're pushy, you can try to just run it. Mind the installer output the
configured PHP version has all the extensions, the warnings for the PHP
versions I did ignore and it all worked.
Replace :dev-master or any of the composer config options in the composer
related goals to control with which version you would like to run.
Display is optimized for composer 2, log has all standard error, standard
output is unfiltered.
https://gist.github.com/ktomk/30149eec13fa6ed7374cdae5d2ef86f9
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEDWUVKYSTTTM6UPVGTTQZIUXANCNFSM4WHFWJPA>
.
|
the code I test it with is not of php 8 syntax, true. the composer 2 message nugged me, so I just put in some force. |
Note: this removes BC checks, which are currently not running for PHP 8.x Ref: laminas/laminas-ci-matrix-action#59 Ref: laminas/laminas-ci-matrix-action#60 Ref: Roave/BackwardCompatibilityCheck#283 Ref: Roave/BetterReflection#701
This is being tracked in #324 |
FWIW, it is impossible to support The changes in reflection in PHP are such an amazing pain in the butt that we simply won't be able to get there in any reasonable time: instead, this tool will need to run from PHP 8.0 or PHP 8.1 only. It will still be able to analyze PHP 7.4 (and earlier) code, but running it will require a newer environment. |
Aside from #264, is there anything else that is blocking a PHP 8 compatible release?
P.S. This is a tracking issue for a release that supports PHP 8.
The text was updated successfully, but these errors were encountered: