Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #283

Closed
WyriHaximus opened this issue Jan 18, 2021 · 10 comments · Fixed by #324
Closed

PHP 8 support #283

WyriHaximus opened this issue Jan 18, 2021 · 10 comments · Fixed by #324
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement help wanted
Milestone

Comments

@WyriHaximus
Copy link

Aside from #264, is there anything else that is blocking a PHP 8 compatible release?

P.S. This is a tracking issue for a release that supports PHP 8.

@asgrim
Copy link
Member

asgrim commented Jan 18, 2021

I think BR (which this depends on) already supports PHP 8, but yeah the named params BC break is a big one that will need to go in. Sorry kinda dropped the ball there :/ (#266 is the PR I opened, it is incomplete at the moment)

@Ocramius
Copy link
Member

BetterReflection needs major work: Roave/BetterReflection#701

@Ocramius Ocramius added dependencies Pull requests that update a dependency file enhancement help wanted labels Jan 18, 2021
@asgrim asgrim removed dependencies Pull requests that update a dependency file help wanted labels Jan 18, 2021
@Ocramius Ocramius added this to the 5.1.0 milestone Jan 18, 2021
@asgrim
Copy link
Member

asgrim commented Jan 18, 2021

I think BR (which this depends on) already supports PHP 8,

clearly this is fake news

@asgrim asgrim added dependencies Pull requests that update a dependency file help wanted labels Jan 18, 2021
@sebastianbergmann
Copy link

Any update on this? Thanks!

@Ocramius
Copy link
Member

Ocramius commented May 4, 2021

@sebastianbergmann no work happening here ATM - too much stuff to maintain, and too little time to get it done.

Roave/BetterReflection#701 is still the major issue here.

@ktomk
Copy link

ktomk commented Jun 2, 2021

If you're pushy, you can try to just run it. Mind the installer output the configured PHP version has all the extensions, the warnings for the PHP versions I did ignore and it all worked.

Replace :dev-master or any of the composer config options in the composer related goals to control with which version you would like to run.

Display is optimized for composer 2, log has all standard error, standard output is unfiltered.

https://gist.github.com/ktomk/30149eec13fa6ed7374cdae5d2ef86f9

@Ocramius
Copy link
Member

Ocramius commented Jun 2, 2021 via email

@ktomk
Copy link

ktomk commented Jun 2, 2021

the code I test it with is not of php 8 syntax, true. the composer 2 message nugged me, so I just put in some force.

Ocramius added a commit to Ocramius/GeneratedHydrator that referenced this issue Sep 19, 2021
@Ocramius Ocramius modified the milestones: 5.1.0, 6.0.0 Nov 5, 2021
@Ocramius Ocramius self-assigned this Nov 6, 2021
@Ocramius
Copy link
Member

Ocramius commented Nov 6, 2021

This is being tracked in #324

@Ocramius
Copy link
Member

Ocramius commented Nov 6, 2021

FWIW, it is impossible to support php:^7.4 together with php:~8.0.0 and php:~8.1.0.

The changes in reflection in PHP are such an amazing pain in the butt that we simply won't be able to get there in any reasonable time: instead, this tool will need to run from PHP 8.0 or PHP 8.1 only.

It will still be able to analyze PHP 7.4 (and earlier) code, but running it will require a newer environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants