Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mania.txt #2

Merged
merged 10 commits into from
May 11, 2021
Merged

Update mania.txt #2

merged 10 commits into from
May 11, 2021

Conversation

YoshiAye
Copy link
Contributor

@YoshiAye YoshiAye commented Jan 2, 2019

added 12k
mistake
P 12 KeyImage10D mania-key2D png
P 12 KeyImage10D mania-key1D png
should be
P 12 KeyImage10D mania-key2D png
P 12 KeyImage11D mania-key1D png

added 12k
@RoanH RoanH self-requested a review January 2, 2019 15:41
RoanH
RoanH previously approved these changes Jan 3, 2019
Copy link
Owner

@RoanH RoanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Thank you for taking the time to add this.

I am going to raise the key limit and also go ahead and add 14K, 16K and 18K in order to completely reflect all the options. I'm not sure when exactly I'll merge in these changes, but they'll be released with version 2.2.

I also noticed that the number of mania tabs is really getting quite annoying to navigate. So I might try to merge some of them into a single tab.

@YoshiAye
Copy link
Contributor Author

YoshiAye commented Jan 3, 2019 via email

@RoanH
Copy link
Owner

RoanH commented Jan 4, 2019

Awesome, I'll wait with any releases then.

Do you already know what you'll be working on, so that I don't end up working on the same things?

@YoshiAye
Copy link
Contributor Author

YoshiAye commented Jan 4, 2019 via email

@RoanH
Copy link
Owner

RoanH commented Jan 4, 2019

Ok, awesome. Thank you for helping out!

@YoshiAye YoshiAye closed this Jan 5, 2019
@YoshiAye YoshiAye reopened this Jan 5, 2019
@RoanH RoanH self-requested a review October 1, 2019 15:50
Conflicts:
	osuSkinChecker/src/mania.txt
@RoanH
Copy link
Owner

RoanH commented May 11, 2021

Apologies for the very late merge..., but it'll be in the next release. Thanks again for helping out.

@RoanH RoanH merged commit c2e111f into RoanH:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants