Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog-backend-module-okta): export EntityTransformer types, including example factory usage #1787

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

robbat2
Copy link

@robbat2 robbat2 commented Jan 16, 2025

Export types for OktaGroupEntityTransformer & OktaUserEntityTransformer, and show how they can be used to stack/modify other transformers.

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes - N/A, functional change is two exports only
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes) - N/A
  • Added or updated documentation (if applicable)

@robbat2 robbat2 requested a review from a team as a code owner January 16, 2025 00:36
Copy link
Contributor

@Xantier Xantier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changeset into the PR
image

@robbat2
Copy link
Author

robbat2 commented Jan 17, 2025

woops, my bad, staged the file and missed in the actual commit.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        new file:   .changeset/20250115.md

@robbat2 robbat2 force-pushed the robbat2/okta-transformer branch from 54242f1 to b2a69b2 Compare January 17, 2025 00:15
Xantier
Xantier previously approved these changes Jan 17, 2025
Copy link
Contributor

@Xantier Xantier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@Xantier
Copy link
Contributor

Xantier commented Jan 17, 2025

Few prettier errors to fix and this can be merged

@robbat2
Copy link
Author

robbat2 commented Jan 18, 2025

Few prettier errors to fix and this can be merged

Most of the prettier errors were pre-existing, but I fixed them anyway.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jan 25, 2025
Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
…cluding example factory usage

Signed-off-by: Robin H. Johnson <rjohnson@coreweave.com>
@robbat2 robbat2 force-pushed the robbat2/okta-transformer branch from 02d28c7 to 7d8ea53 Compare January 25, 2025 07:07
@robbat2
Copy link
Author

robbat2 commented Jan 25, 2025

@Xantier prettier should be good now

@github-actions github-actions bot removed the stale label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants