Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issues with tests #12

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix: Fixed issues with tests #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions tests/Riverside.JsonBinder.Tests/JsonSerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
{
[TestMethod]
[DataRow("{\"name\":\"John\"}", SerializableLanguage.CSharp, "public class Root\n{\n public string name { get; set; }\n}")]
[DataRow("{\"name\":\"John\"}", SerializableLanguage.Python, "class Root:\n def __init__(self):\n self.name: str = None")]
[DataRow("{\"name\":\"John\"}", SerializableLanguage.Java, "public class Root {\n private String name;\n public String getname() { return name; }\n public void setname(String name) { this.name = name; }\n}")]
[DataRow("{\"name\":\"John\"}", SerializableLanguage.Python, "class Root:\n name: Optional[str]\n\n def __init__(self):\n self.name: str = None")]
[DataRow("{\"name\":\"John\"}", SerializableLanguage.Java, "public class Root {\n private String name;\n\n public String getname() { return name; }\n public void setname(String name) { this.name = name; }\n}")]
public void ConvertTo_ValidJson_ReturnsExpectedResult(string json, SerializableLanguage language, string expected)
{
// Act
Expand Down Expand Up @@ -43,7 +43,7 @@
// Arrange
string? invalidJson = null;

JsonSerializer.ConvertTo(invalidJson, SerializableLanguage.CSharp);

Check warning on line 46 in tests/Riverside.JsonBinder.Tests/JsonSerializerTests.cs

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, Debug) 

Possible null reference argument for parameter 'json' in 'string JsonSerializer.ConvertTo(string json, SerializableLanguage language)'.

Check warning on line 46 in tests/Riverside.JsonBinder.Tests/JsonSerializerTests.cs

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, Release) 

Possible null reference argument for parameter 'json' in 'string JsonSerializer.ConvertTo(string json, SerializableLanguage language)'.

Check warning on line 46 in tests/Riverside.JsonBinder.Tests/JsonSerializerTests.cs

View workflow job for this annotation

GitHub Actions / Build (windows-latest, Debug) 

Possible null reference argument for parameter 'json' in 'string JsonSerializer.ConvertTo(string json, SerializableLanguage language)'.

Check warning on line 46 in tests/Riverside.JsonBinder.Tests/JsonSerializerTests.cs

View workflow job for this annotation

GitHub Actions / Build (windows-latest, Release) 

Possible null reference argument for parameter 'json' in 'string JsonSerializer.ConvertTo(string json, SerializableLanguage language)'.
}

[TestMethod]
Expand All @@ -65,17 +65,12 @@
string expected = """
public class Root
{
public List<Items> Items { get; set; }
public List<ItemsItem> Items { get; set; }
}

public class ItemsItem
{
public string name { get; set; }
}

public class Items
{
public List<ItemsItem> Items { get; set; } = new List<ItemsItem>();
public string Name { get; set; }
}
""";
// Act
Expand Down
4 changes: 2 additions & 2 deletions tests/Riverside.JsonBinder.Tests/LanguageSerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ public void GenerateClasses_InvalidJson_ThrowsException(SerializableLanguage lan

public static IEnumerable<object[]> GetTestData()
{
yield return new object[] { SerializableLanguage.CSharp, "{\"name\":\"John\"}", "public class Root\n{\n public string name { get; set; }\n}" };
yield return new object[] { SerializableLanguage.CSharp, "{\"name\":\"John\"}", "public class Root\n{\n public string Name { get; set; }\n}" };
yield return new object[] { SerializableLanguage.Python, "{\"name\":\"John\"}", "class Root:\n def __init__(self):\n self.name: str = None" };
yield return new object[] { SerializableLanguage.Java, "{\"name\":\"John\"}", "public class Root {\n private String name;\n public String getname() { return name; }\n public void setname(String name) { this.name = name; }\n}" };
yield return new object[] { SerializableLanguage.Java, "{\"name\":\"John\"}", "public class Root {\n private String name;\n\n public String getname() { return name; }\n public void setname(String name) { this.name = name; }\n}" };
yield return new object[] { SerializableLanguage.JavaScript, "{\"name\":\"John\"}", "class Root {\n constructor() {\n this.name = null;\n }\n}" };
yield return new object[] { SerializableLanguage.TypeScript, "{\"name\":\"John\"}", "class Root {\n constructor() {\n this.name = null;\n }\n}" };
yield return new object[] { SerializableLanguage.PHP, "{\"name\":\"John\"}", "class Root {\n public $name;\n}" };
Expand Down
Loading