fix: removing unecessary subtype in connectors initialization in tests

Riminder · Sep 2, 2024 · e3bff24 · e3bff24
1 parent d7f0960
commit e3bff24
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 26 deletions.
diff --git a/tests/core/test_connector.py b/tests/core/test_connector.py
@@ -39,7 +39,6 @@
 SmartLeadsF = lambda: Connector(
     name="SmartLeads",
     type=ConnectorType.Other,
-    subtype="smartleads",
     description=DESCRIPTION,
     url="https://www.smartleads.test/",
     actions=[
@@ -95,7 +94,6 @@ def test_action_name_constraint():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
-            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -121,7 +119,6 @@ def test_action_pull_profile_list_only_with_trigger_type_pull():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
-            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -151,7 +148,6 @@ def test_action_pull_job_list_only_with_trigger_type_pull():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
-            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -181,7 +177,6 @@ def test_action_pull_application_list_only_with_trigger_type_pull():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
-            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -259,7 +254,6 @@ def test_origin_warehouse_failure():
     connector = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
-        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -291,7 +285,6 @@ def test_origin_not_readable_failure():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
-            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -316,7 +309,6 @@ def test_target_warehouse_failure():
     connector = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
-        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -348,7 +340,6 @@ def test_target_not_writable_failure():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
-            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -514,7 +505,6 @@ def smarter_format(user):
     EvenSmarterLeads = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
-        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -599,7 +589,6 @@ def failing_logic(user):
     FailingSmartLeads = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
-        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -746,7 +735,6 @@ def callback(origin_parameters, target_parameters, events, written_items) -> Non
     SmartLeads = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
-        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -791,7 +779,6 @@ def callback(origin_parameters, target_parameters, events, written_items) -> Non
     SmartLeads = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
-        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -1292,7 +1279,6 @@ def test_connector_based_on_simple():
         base=SmartLeads,
         name="SmartLeadsCopy",
         type=ConnectorType.Other,
-        subtype="smartleadscopy",
         description="SmartLeadsCopy",
         url="Some URL",
     )
@@ -1316,7 +1302,6 @@ def test_connector_based_on_action_override():
         base=SmartLeads,
         name="SmartLeadsCopy",
         type=ConnectorType.Other,
-        subtype="smartleadscopy",
         description="SmartLeadsCopy",
         url="Some URL",
         with_actions=[
@@ -1362,7 +1347,6 @@ def test_connector_based_on_new_action():
         base=SmartLeads,
         name="SmartLeadsCopy",
         type=ConnectorType.Other,
-        subtype="smartleadscopy",
         description="SmartLeadsCopy",
         url="Some URL",
         with_actions=[
@@ -1417,7 +1401,6 @@ def new_event_parser(*args, **kwargs):
         base=SmartLeads,
         name="SmartLeadsCopy",
         type=ConnectorType.Other,
-        subtype="smartleadscopy",
         description="SmartLeadsCopy",
         url="Some URL",
         with_parameters_override=[
@@ -1487,7 +1470,6 @@ def new_event_parser(*args, **kwargs):
         base=SmartLeads,
         name="SmartLeadsCopy",
         type=ConnectorType.Other,
-        subtype="smartleadscopy",
         description="SmartLeadsCopy",
         url="Some URL",
         with_parameters_override=[
@@ -1631,7 +1613,6 @@ def new_format(*args, **kwargs):
             base=SmartLeads,
             name="SmartLeadsCopy",
             type=ConnectorType.Other,
-            subtype="smartleadscopy",
             description="SmartLeadsCopy",
             url="Some URL",
             with_parameters_override=[
@@ -1663,7 +1644,6 @@ def new_format(*args, **kwargs):
             base=SmartLeads,
             name="SmartLeadsCopy",
             type=ConnectorType.Other,
-            subtype="smartleadscopy",
             description="SmartLeadsCopy",
             url="Some URL",
             with_parameters_override=[

diff --git a/tests/core/test_documentation.py b/tests/core/test_documentation.py
@@ -51,7 +51,6 @@
 SmartLeads = Connector(
     name="SmartLeads",
     type=ConnectorType.Other,
-    subtype="smartleads",
     description=DESCRIPTION,
     url="https://www.smartleads.test/",
     actions=[
@@ -644,7 +643,6 @@ def test_documentation_connector_directory_not_found(caplog, connectors_director
     NameMismatchSmartLeads = Connector(
         name=mismatch_name,
         type=ConnectorType.Other,
-        subtype="noconnectordir",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -718,7 +716,6 @@ def test_documentation_fails_if_connector_not_already_listed_in_root_readme(
     NotListed = Connector(
         name=name,
         type=ConnectorType.Other,
-        subtype="notlistedinrootreadme",
         description=DESCRIPTION,
         url="https://not.listed.in.root.test/",
         actions=[

diff --git a/tests/core/test_templates.py b/tests/core/test_templates.py
@@ -27,7 +27,6 @@
 SmartLeads = Connector(
     name="SmartLeads",
     type=ConnectorType.Other,
-    subtype="smartleads",
     description=DESCRIPTION,
     url="https://www.smartleads.test/",
     actions=[

diff --git a/tests/core/test_tests.py b/tests/core/test_tests.py
@@ -33,7 +33,6 @@
 SmartLeads = Connector(
     name="SmartLeads",
     type=ConnectorType.Other,
-    subtype="smartleads",
     description="Test Connector for seamless users to leads integration",
     url="https://www.smartleads.test/",
     actions=[
@@ -60,7 +59,6 @@
 LocalUsers = Connector(
     name="LocalUsers",
     type=ConnectorType.Other,
-    subtype="localusers",
     description="Local users connector",
     url="https://www.localusers.test/",
     actions=[],