core: making subtype property from Connector object mandatory

src/hrflow_connectors/connectors/adzuna/connector.py

@@ -58,6 +58,7 @@ def format_job(
 Adzuna = Connector(
     name="Adzuna",
     type=ConnectorType.JobBoard,
+    subtype="adzuna",
     description="Retrieve Adzuna's job, property and car advertisement listings.",
     url="https://www.adzuna.fr/",
     actions=[

src/hrflow_connectors/connectors/breezyhr/connector.py

@@ -269,6 +269,7 @@ def format_candidate(breezy_profile: BreezyProfileModel) -> HrFlowProfile:
 BreezyHR = Connector(
     name="BreezyHR",
     type=ConnectorType.ATS,
+    subtype="breezyhr",
     description=(
         "Breezyhr is an end-to-end recruiting software "
         "to help you attract & hire great employees with less effort"

src/hrflow_connectors/connectors/bullhorn/connector.py

@@ -409,6 +409,7 @@ def format_application(data: HrFlowProfile) -> t.Dict:
 Bullhorn = Connector(
     name="Bullhorn",
     type=ConnectorType.ATS,
+    subtype="bullhorn",
     description=DESCRIPTION,
     url="https://www.bullhorn.com/",
     actions=[

src/hrflow_connectors/connectors/carrevolutis/connector.py

@@ -65,6 +65,7 @@ def event_parser(event: t.Dict) -> t.Dict:
 Carrevolutis = Connector(
     name="Carrevolutis",
     type=ConnectorType.JobBoard,
+    subtype="carrevolutis",
     description=DESCRIPTION,
     url="https://www.carrevolutis.com/",
     actions=[

src/hrflow_connectors/connectors/ceridian/connector.py

@@ -80,6 +80,7 @@ def format_job(data: CeridianDayforceJobModel) -> t.Dict:
 Ceridian = Connector(
     name="Ceridian",
     type=ConnectorType.HCM,
+    subtype="ceridian",
     description=DESCRIPTION,
     url="https://www.ceridian.com/",
     actions=[

src/hrflow_connectors/connectors/digitalrecruiters/connector.py

@@ -321,6 +321,7 @@ def format_profile(profile_hrflow: t.Dict) -> t.Dict:
 DigitalRecruiters = Connector(
     name="DigitalRecruiters",
     type=ConnectorType.ATS,
+    subtype="digitalrecruiters",
     description=DESCRIPTION,
     url="https://www.digitalrecruiters.com/",
     actions=[

src/hrflow_connectors/connectors/greenhouse/connector.py

@@ -225,6 +225,7 @@ def format_to_hrflow_profile(data):
 Greenhouse = Connector(
     name="Greenhouse",
     type=ConnectorType.ATS,
+    subtype="greenhouse",
     description="",
     url="https://www.greenhouse.io/",
     actions=[

src/hrflow_connectors/connectors/hubspot/connector.py

@@ -64,6 +64,7 @@ def format_hubspot_contact(hubspot_contact: t.Dict) -> t.Dict:
 Hubspot = Connector(
     name="Hubspot",
     type=ConnectorType.CRM,
+    subtype="hubspot",
     description="",
     url="https://www.hubspot.com/",
     actions=[

src/hrflow_connectors/connectors/jobology/connector.py

@@ -63,6 +63,7 @@ def event_parser(event: t.Dict) -> t.Dict:
 Jobology = Connector(
     name="Jobology",
     type=ConnectorType.JobBoard,
+    subtype="jobology",
     description=DESCRIPTION,
     url="https://www.jobology.fr/",
     actions=[

src/hrflow_connectors/connectors/lever/connector.py

@@ -403,6 +403,7 @@ def format_opportunity(hrflow_profile: dict) -> dict:
 Lever = Connector(
     name="Lever",
     type=ConnectorType.ATS,
+    subtype="lever",
     description=DESCRIPTION,
     url="https://www.lever.co/",
     actions=[

src/hrflow_connectors/connectors/meteojob/connector.py

@@ -63,6 +63,7 @@ def event_parser(event: t.Dict) -> t.Dict:
 Meteojob = Connector(
     name="Meteojob",
     type=ConnectorType.JobBoard,
+    subtype="meteojob",
     description=DESCRIPTION,
     url="https://www.meteojob.com/",
     actions=[

src/hrflow_connectors/connectors/poleemploi/connector.py

@@ -102,6 +102,7 @@ def format_job(
 PoleEmploi = Connector(
     name="PoleEmploi",
     type=ConnectorType.JobBoard,
+    subtype="poleemploi",
     description=DESCRIPTION,
     url="https://www.pole-emploi.fr/",
     actions=[

src/hrflow_connectors/connectors/recruitee/connector.py

@@ -200,6 +200,7 @@ def format_job(recruitee_job: t.Dict) -> t.Dict:
 Recruitee = Connector(
     name="Recruitee",
     type=ConnectorType.ATS,
+    subtype="recruitee",
     description="",
     url="https://recruitee.com/",
     actions=[

src/hrflow_connectors/connectors/salesforce/connector.py

@@ -273,6 +273,7 @@ def format_job(data: SalesforceHrFlowJob) -> t.Dict:
 Salesforce = Connector(
     name="Salesforce",
     type=ConnectorType.CRM,
+    subtype="salesforce",
     description=DESCRIPTION,
     url="https://www.salesforce.com",
     actions=[

src/hrflow_connectors/connectors/sapsuccessfactors/connector.py

@@ -301,6 +301,7 @@ def format_sap_candidate(candidate_data: t.Dict) -> t.Dict:
 SAPSuccessFactors = Connector(
     name="SAPSuccessFactors",
     type=ConnectorType.ATS,
+    subtype="sapsuccessfactors",
     description=DESCRIPTION,
     url="https://www.sap.com/",
     actions=[

src/hrflow_connectors/connectors/smartrecruiters/connector.py

@@ -183,6 +183,7 @@ def format_profile(hrflow_profile: t.Dict) -> t.Dict:
 SmartRecruiters = Connector(
     name="SmartRecruiters",
     type=ConnectorType.ATS,
+    subtype="smartrecruiters",
     description=DESCRIPTION,
     url="https://www.smartrecruiters.com/",
     actions=[

src/hrflow_connectors/connectors/taleez/connector.py

@@ -358,6 +358,7 @@ def format_job(taleez_job: t.Dict) -> t.Dict:
 Taleez = Connector(
     name="Taleez",
     type=ConnectorType.ATS,
+    subtype="taleez",
     description=DESCRIPTION,
     url="https://taleez.com/",
     actions=[

src/hrflow_connectors/connectors/talentsoft/connector.py

@@ -440,6 +440,7 @@ def format_info_ts_applicant(profile_hrflow: t.Dict) -> t.Dict:
 TalentSoft = Connector(
     name="TalentSoft",
     type=ConnectorType.HCM,
+    subtype="talentsoft",
     description=DESCRIPTION,
     url="https://www.cegid.com/fr/produits/cegid-talentsoft/",
     actions=[

src/hrflow_connectors/connectors/teamtailor/connector.py

@@ -128,6 +128,7 @@ def format_profile(data: HrFlowProfile) -> t.Dict:
 Teamtailor = Connector(
     name="Teamtailor",
     type=ConnectorType.ATS,
+    subtype="teamtailor",
     description=DESCRIPTION,
     url="https://www.teamtailor.com/",
     actions=[

src/hrflow_connectors/connectors/waalaxy/connector.py

@@ -55,6 +55,7 @@ def event_parser(event: t.Dict) -> t.Dict:
 Waalaxy = Connector(
     name="Waalaxy",
     type=ConnectorType.Automation,
+    subtype="waalaxy",
     description=DESCRIPTION,
     url="https://www.waalaxy.com/fr/",
     actions=[

src/hrflow_connectors/connectors/workable/connector.py

@@ -144,6 +144,7 @@ def format_profile(
 Workable = Connector(
     name="Workable",
     type=ConnectorType.HCM,
+    subtype="workable",
     description=(
         "More than an applicant tracking system, "
         "Workable's talent acquisition software helps teams find candidates, "

src/hrflow_connectors/core/connector.py

@@ -764,25 +764,12 @@ class ConnectorModel(BaseModel):
     description: str
     url: str
     type: ConnectorType
-    subtype: t.Optional[str] = Field(
+    subtype: str = Field(
         regex=CONNECTOR_SUBTYPE_FORMAT_REGEX,
         description="Lowercased string with no spaces",
     )
     actions: t.List[ConnectorAction]
 
-    @validator("subtype", pre=True, always=True)
-    def check_subtype(cls, value: t.Optional[str], values: dict) -> str:
-        if value is None:
-            cleaned_value = values.get("name", "").lower().replace(" ", "")
-        else:
-            cleaned_value = value.lower().replace(" ", "")
-            if cleaned_value != value:
-                raise ValueError(
-                    "ConnectorModel's `subtype`={} must be lowercase without any"
-                    " spaces.".format(value)
-                )
-        return cleaned_value
-
     def logo(self, connectors_directory: Path) -> str:
         try:
             from PIL import Image, UnidentifiedImageError
@@ -861,11 +848,11 @@ def based_on(
         base: t.Self,
         name: str,
         type: ConnectorType,
+        subtype: str,
         description: str,
         url: str,
         with_parameters_override: t.Optional[t.List[ParametersOverride]] = None,
         with_actions: t.Optional[t.List[ConnectorAction]] = None,
-        subtype: t.Optional[str] = None,
     ) -> t.Self:
         base_actions = base.model.actions
 
@@ -913,7 +900,7 @@ def based_on(
         connector = cls(
             name=name,
             type=type,
-            subtype=name.lower().replace(" ", "") if subtype is None else subtype,
+            subtype=subtype,
             description=description,
             url=url,
             actions=list(actions.values()),

tests/core/test_connector.py

@@ -39,6 +39,7 @@
 SmartLeadsF = lambda: Connector(
     name="SmartLeads",
     type=ConnectorType.Other,
+    subtype="smartleads",
     description=DESCRIPTION,
     url="https://www.smartleads.test/",
     actions=[
@@ -94,6 +95,7 @@ def test_action_name_constraint():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
+            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -119,6 +121,7 @@ def test_action_pull_profile_list_only_with_trigger_type_pull():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
+            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -148,6 +151,7 @@ def test_action_pull_job_list_only_with_trigger_type_pull():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
+            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -177,6 +181,7 @@ def test_action_pull_application_list_only_with_trigger_type_pull():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
+            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -254,6 +259,7 @@ def test_origin_warehouse_failure():
     connector = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
+        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -285,6 +291,7 @@ def test_origin_not_readable_failure():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
+            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -309,6 +316,7 @@ def test_target_warehouse_failure():
     connector = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
+        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -340,6 +348,7 @@ def test_target_not_writable_failure():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
+            subtype="smartleads",
             description=DESCRIPTION,
             url="https://www.smartleads.test/",
             actions=[
@@ -505,6 +514,7 @@ def smarter_format(user):
     EvenSmarterLeads = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
+        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -589,6 +599,7 @@ def failing_logic(user):
     FailingSmartLeads = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
+        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -735,6 +746,7 @@ def callback(origin_parameters, target_parameters, events, written_items) -> Non
     SmartLeads = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
+        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -779,6 +791,7 @@ def callback(origin_parameters, target_parameters, events, written_items) -> Non
     SmartLeads = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
+        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -1674,6 +1687,7 @@ def test_connector_model_subtype_missing():
     model = Connector(
         name="SmartLeads",
         type=ConnectorType.Other,
+        subtype="smartleads",
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[],
@@ -1687,6 +1701,7 @@ def test_connector_subtype_constraint():
         Connector(
             name="SmartLeads",
             type=ConnectorType.Other,
+            subtype="smartleads",
             subtype=subtype,
             description=DESCRIPTION,
             url="https://www.smartleads.test/",

tests/core/test_documentation.py

@@ -51,6 +51,7 @@
 SmartLeads = Connector(
     name="SmartLeads",
     type=ConnectorType.Other,
+    subtype="smartleads",
     description=DESCRIPTION,
     url="https://www.smartleads.test/",
     actions=[
@@ -643,6 +644,7 @@ def test_documentation_connector_directory_not_found(caplog, connectors_director
     NameMismatchSmartLeads = Connector(
         name=mismatch_name,
         type=ConnectorType.Other,
+        subtype=mismatch_name.lower().replace(" ", ""),
         description=DESCRIPTION,
         url="https://www.smartleads.test/",
         actions=[
@@ -716,6 +718,7 @@ def test_documentation_fails_if_connector_not_already_listed_in_root_readme(
     NotListed = Connector(
         name=name,
         type=ConnectorType.Other,
+        subtype=name.lower().replace(" ", ""),
         description=DESCRIPTION,
         url="https://not.listed.in.root.test/",
         actions=[

tests/core/test_templates.py

@@ -27,6 +27,7 @@
 SmartLeads = Connector(
     name="SmartLeads",
     type=ConnectorType.Other,
+    subtype="smartleads",
     description=DESCRIPTION,
     url="https://www.smartleads.test/",
     actions=[

tests/core/test_tests.py

@@ -33,6 +33,7 @@
 SmartLeads = Connector(
     name="SmartLeads",
     type=ConnectorType.Other,
+    subtype="smartleads",
     description="Test Connector for seamless users to leads integration",
     url="https://www.smartleads.test/",
     actions=[
@@ -59,6 +60,7 @@
 LocalUsers = Connector(
     name="LocalUsers",
     type=ConnectorType.Other,
+    subtype="localusers",
     description="Local users connector",
     url="https://www.localusers.test/",
     actions=[],