Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airplane dashboard mouse control #3216

Closed
CuriousMike56 opened this issue Jan 21, 2025 · 2 comments · Fixed by #3224
Closed

Airplane dashboard mouse control #3216

CuriousMike56 opened this issue Jan 21, 2025 · 2 comments · Fixed by #3224
Labels
bug GUI

Comments

@CuriousMike56
Copy link
Member

The mouse is no longer able to interact with the airplane dashboard. This has been an issue for a few months now, unsure of the offending commit.
@ohlidalp
Copy link
Member

My prime suspect: d10cb2a

@ohlidalp
Copy link
Member

ohlidalp commented Jan 29, 2025 •
edited
Loading

I found the problem: wrong viewport dimensions used when calculating relative mouse position to query for overlay element. Broken in #3184 as I suspected. Before that, we queried both mouse position and viewport dimensions directly from OIS. I had to change that because of OIS bug, and now the dimension values are not updated correctly

I'll try to make a future-proof solution with #2983 in mind.

EDIT: I ended up doing a minimum viable solution :)

ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Jan 29, 2025
@ohlidalp
Fixes RigsOfRods#3216 - Airplane dashboard not reacting to mouse
d7f9199 
_problem: _
wrong viewport dimensions used when calculating relative mouse position to query for overlay element.
Broken in RigsOfRods#3184. Before that, we queried both mouse position and viewport dimensions directly from OIS.
I had to change that because of OIS bug, and now the dimension values are not updated correctly.

_solution:_
Minimum viable fix - just keep the same dummy OIS event, just update the viewport dimensions.
@ohlidalp ohlidalp mentioned this issue Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aerial HUD fixes + new mouse-hover highlights ohlidalp/rigs-of-rods
2 participants
@ohlidalp @CuriousMike56