fix: minor fixes #642
Merged
fix: minor fixes #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix uni decoder decoded actions - do not return revert error when calling ExtensionsMap, as contract is known and will always return something - add native transfer custom revert error in uni router - update eth-related tests
- use try/catch statement and revert with custom error in safeApprove
- add reverts in uncovered revert scenarios
- correctly append value for mint, increasase position - revert when trying to increase and mint (mint already increases liquidity) - process tokenIds before forwarding calldata to uniV4Posm
- use low-level call for force approve - added test with non-standard ERC20
- define tokens array in memory and fix index - add test to assert removing a token from a list with multiple active tokens works correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Overview