Skip to content

Commit

Permalink
Merge pull request #378 from RigoBlock/fix/update-version
Browse files Browse the repository at this point in the history
fix: update version in implementation deployment constants
  • Loading branch information
gabririgo authored Nov 10, 2023
2 parents 3279ffb + 0bb17d3 commit 3c95011
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion contracts/protocol/core/immutable/MixinConstants.sol
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import "../../IRigoblockV3Pool.sol";
/// @dev Inheriting from interface is required as we override public variables.
abstract contract MixinConstants is IRigoblockV3Pool {
/// @inheritdoc IRigoblockV3PoolImmutable
string public constant override VERSION = "HF 3.1.1";
string public constant override VERSION = "HF 3.1.2";

bytes32 internal constant _POOL_INIT_SLOT = 0xe48b9bb119adfc3bccddcc581484cc6725fe8d292ebfcec7d67b1f93138d8bd8;

Expand Down
4 changes: 3 additions & 1 deletion test/core/RigoblockPool.Basetoken.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ describe("BaseTokenProxy", async () => {
const { pool } = await setupTests()
const authority = await deployments.get("Authority")
expect(await pool.authority()).to.be.eq(authority.address)
expect(await pool.VERSION()).to.be.eq('HF 3.1.1')
// TODO: we should have an assertion that the version is different if implementation has changed
// so we are prompted to change the version in the deployment constants.
expect(await pool.VERSION()).to.be.eq('HF 3.1.2')
})
})

Expand Down

0 comments on commit 3c95011

Please sign in to comment.