Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-lightning deprecations #35

Closed
darosior opened this issue Mar 25, 2020 · 5 comments
Closed

C-lightning deprecations #35

darosior opened this issue Mar 25, 2020 · 5 comments

Comments

@darosior
Copy link

Hi,

For your interest ElementsProject/lightning#3603 removes some fields in the API which have been deprecated for several (6 iirc) months.

Namely:

  • The description field in sendpay.
  • The satoshi field in fundchannel_start (now amount). Note also this commit ElementsProject/lightning@49e2153 .
  • No more localfeatures and globalfeatures fields in listnodes, listpeers, peer_connected.
  • No more force bool in close.

Since now RTL relies on your wrapper, just wanted you to know ! 😃

@saubyk
Copy link
Collaborator

saubyk commented Mar 25, 2020

@darosior thanks for letting me know.

@rustyrussell
Copy link

Note: you should always test with "enable-deprecated-apis=false" (but ship without that!) so you'll find things when we deprecate it, not 6 months later when we remove it!

@saubyk
Copy link
Collaborator

saubyk commented Mar 31, 2020

@jamaljsr @kaloudis @ShahanaFarooqui
Please note the deprecations above. These fields will be removed from c-lightning v0.8.2.
Please plan to remove these fields from your respective UIs if you are using them.

@jamaljsr
Copy link
Contributor

@saubyk thanks for the heads up 👍

@saubyk
Copy link
Collaborator

saubyk commented Aug 25, 2020

Closing this ticket. As deprecations are addressed.

@saubyk saubyk closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants