Skip to content

Commit

Permalink
fundchannel_start: We can't deprecate 'satoshi' here, since 'amount' …
Browse files Browse the repository at this point in the history
…wasn't sent

So we can't tell people they should use amount, until v0.8.2 is
released.  Another 6 months before we can deprecated the 'satoshi'
field here :(

Fixes: d149ba2
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: JSON: `fundchannel_start` returns `amount` even when deprecated APIs are enabled.
Changelog-Deprecated: JSON: `fundchannel_start` `satoshi` field really deprecated now (use `amount`).
  • Loading branch information
rustyrussell committed Mar 25, 2020
1 parent ce5b3be commit 49e2153
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions plugins/fundchannel.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,7 @@ static struct command_result *fundchannel_start(struct command *cmd,

if (deprecated_apis)
json_add_string(req->js, "satoshi", fr->funding_str);
else
json_add_string(req->js, "amount", fr->funding_str);
json_add_string(req->js, "amount", fr->funding_str);

if (fr->feerate_str)
json_add_string(req->js, "feerate", fr->feerate_str);
Expand Down

0 comments on commit 49e2153

Please sign in to comment.