-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added info about some more emulators and polished a bit #83
Conversation
Alright, I got everything fixed and since I had the time to do it, I added and fixed some other stuff ;3 |
Please realize that while you may be "too lazy" to make another commit to the branch, you're asking me to expend quite a bit of time to review a raw markdown file. This really isn't going to work. If you need help getting set up or acclimated with Git, I'm sure someone on QAM or the Writing Team would be more than happy to assist. |
Fixed version requested by @wescopeland
https://github.com/SuperGamer18/docs/blob/patch-1/docs/general/emulator-support-and-issues.md I finally got it, the real issue was that the device I originally made these changes with was very underpowered. Sorry for what happened here, I'll try to be more mindful of these kinds of situations next time (I hope this is reviewable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reviewable. Thank you for the follow-up & your understanding.
@@ -170,6 +170,7 @@ description: Comprehensive guide to emulator support and compatibility for Retro | |||
- ❌ _Not supported_ - needs hashing method and memory map | |||
- ❌ libretro core: **gw** | |||
- Does not expose memory | |||
- Uses recreations (by MADrigal) instead of actual Game & Watch ROMs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove this too - this seems like a libretro implementation detail.
|
||
- ✅ Standalone emulator: **[RANes](https://retroachievements.org/download.php#ranes)** | ||
- ✅ Standalone emulator: **[RANes](https:retroachievements.org/download.php#ranes)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is now broken.
@@ -347,7 +349,6 @@ description: Comprehensive guide to emulator support and compatibility for Retro | |||
- Limited microphone support | |||
- ✅ libretro core: **DeSmuME** | |||
- ✅ libretro core: **DeSmuME 2015** | |||
- ✅ libretro core: **melonDS** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We support the melonDS libretro core. Please revert.
@@ -537,7 +539,7 @@ description: Comprehensive guide to emulator support and compatibility for Retro | |||
|
|||
### Sharp X1 | |||
|
|||
- ❌ _Not supported_ - needs hashing method and memory map | |||
- ❌ _Not supported_- needs hashing method and memory map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's re-add the whitespace before the dash.
@@ -685,4 +693,4 @@ description: Comprehensive guide to emulator support and compatibility for Retro | |||
- Hashing needs to be corrected | |||
- Testing | |||
|
|||
More details on BizHawk cores can be found [here](https://tasvideos.org/BizHawk). | |||
More details on BizHawk cores can be found [here.](https://tasvideos.org/BizHawk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more proper to exclude the punctuation from the hyperlink label.
Fixed yet again
https://github.com/SuperGamer18/docs/blob/patch-1/docs/general/emulator-support-and-issues.md Fixed, yet again. Two things I wanna note though: |
|
1: You're welcome, man! To be honest, it isn't hard to figure out why this is one of the most visited pages on the docs and the website in general, it's literally linked right at the home page of |
@SuperGamer18 Not sure what happened - I was tied up with work and wasn't able to give final approval. If you'd like to reopen the PR I'm happy to walk through getting it merged. |
Damn, just as I was fixing the Spanish translation. Oh well, guess I'll take my time to improve the English version even further and update the Spanish version to be on par with the former. BTW should I have both in the same PR or should I open separate PRs for each language? |
Affected file: emulator-support-and-issues.md
So, as the title says, I added info on a few more emulators and generally polished it. What exactly have I changed? (Yes, I know you could check the history for comparing versions but I'll list the stuff I've changed here anyways)
Also keep in mind I may have missed some things. If so, please let me know!
And that should be it, I think.