Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info about some more emulators and polished a bit #83

Closed
wants to merge 5 commits into from

Conversation

SuperGamer18
Copy link
Contributor

Affected file: emulator-support-and-issues.md
So, as the title says, I added info on a few more emulators and generally polished it. What exactly have I changed? (Yes, I know you could check the history for comparing versions but I'll list the stuff I've changed here anyways)
Also keep in mind I may have missed some things. If so, please let me know!

  • Replaced all instances of underscore (_) with asterisk (*) for consistency reasons
  • Added 64/ before the 128 in Enterprise 128
  • Added the fact that the games played in the gw libretro core are recreations
  • Added extra info about how to use RetroAchievements in Dolphin
  • Properly capitalized/fixed some of the emulator names
  • Added extra standalone emulators and info about them such as Citra, PICO-8, Infuse, etc.
  • Added info about DeSmuME not supporting DSi
  • Added info about what NetherSX2 is (a mod of AetherSX2)
  • Extra emphasis on "recommended" in the Sega Saturn section
  • Removed an exclamation mark (!) in the Snes9x 2010 part
  • Added info about VeMUlator not supporting savestates
  • Marked the libretro core version of Dolphin as not supported (❌) for achievements (applies both to GameCube and Wii)
    And that should be it, I think.

@SuperGamer18
Copy link
Contributor Author

Alright, I got everything fixed and since I had the time to do it, I added and fixed some other stuff ;3
Here's the new file:
emulator-support-and-issues.md
(I was too lazy to make another commit in my fork or whatever, this is the first time I ever edited the docs page as well as the first time I ever made a pull request and a fork, I wasn't aware about some of this stuff as I'm not a GitHub nerd)

@SuperGamer18 SuperGamer18 requested a review from wescopeland July 31, 2024 17:49
@wescopeland
Copy link
Member

wescopeland commented Jul 31, 2024

I was too lazy to make another commit in my fork or whatever

Please realize that while you may be "too lazy" to make another commit to the branch, you're asking me to expend quite a bit of time to review a raw markdown file. This really isn't going to work.

If you need help getting set up or acclimated with Git, I'm sure someone on QAM or the Writing Team would be more than happy to assist.

@wescopeland wescopeland removed their request for review July 31, 2024 17:55
@SuperGamer18
Copy link
Contributor Author

https://github.com/SuperGamer18/docs/blob/patch-1/docs/general/emulator-support-and-issues.md I finally got it, the real issue was that the device I originally made these changes with was very underpowered. Sorry for what happened here, I'll try to be more mindful of these kinds of situations next time (I hope this is reviewable)

@SuperGamer18 SuperGamer18 requested a review from wescopeland July 31, 2024 18:09
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reviewable. Thank you for the follow-up & your understanding.

@@ -170,6 +170,7 @@ description: Comprehensive guide to emulator support and compatibility for Retro
- ❌ _Not supported_ - needs hashing method and memory map
- ❌ libretro core: **gw**
- Does not expose memory
- Uses recreations (by MADrigal) instead of actual Game & Watch ROMs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove this too - this seems like a libretro implementation detail.


- ✅ Standalone emulator: **[RANes](https://retroachievements.org/download.php#ranes)**
- ✅ Standalone emulator: **[RANes](https:retroachievements.org/download.php#ranes)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is now broken.

@@ -347,7 +349,6 @@ description: Comprehensive guide to emulator support and compatibility for Retro
- Limited microphone support
- ✅ libretro core: **DeSmuME**
- ✅ libretro core: **DeSmuME 2015**
- ✅ libretro core: **melonDS**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -537,7 +539,7 @@ description: Comprehensive guide to emulator support and compatibility for Retro

### Sharp X1

- ❌ _Not supported_ - needs hashing method and memory map
- ❌ _Not supported_- needs hashing method and memory map
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's re-add the whitespace before the dash.

@@ -685,4 +693,4 @@ description: Comprehensive guide to emulator support and compatibility for Retro
- Hashing needs to be corrected
- Testing

More details on BizHawk cores can be found [here](https://tasvideos.org/BizHawk).
More details on BizHawk cores can be found [here.](https://tasvideos.org/BizHawk)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more proper to exclude the punctuation from the hyperlink label.

@SuperGamer18
Copy link
Contributor Author

https://github.com/SuperGamer18/docs/blob/patch-1/docs/general/emulator-support-and-issues.md Fixed, yet again. Two things I wanna note though:
1: I may have accidentally done some of these mistakes when editing and I didn't realize them. Sorry.
2: I'm kinda confused about the MelonDS thing because for the DSi section you asked me to keep the extra DS in "MelonDS DS" but in the regular DS section you wanted me to remove it.

@wescopeland
Copy link
Member

  1. No worries, that is why we have docs reviews. This is one of the most-visited pages under all of retroachievements.org, so it's important that the content is heavily vetted. Overall, what we've whittled down to is an improvement. Thank you!

  2. "melonDS" and "melonDS DS" are two different libretro cores, both of which are supported.

@SuperGamer18
Copy link
Contributor Author

1: You're welcome, man! To be honest, it isn't hard to figure out why this is one of the most visited pages on the docs and the website in general, it's literally linked right at the home page of docs.retroachievements.org! (And I'm pretty sure many users have issues in choosing which core should they use to get those cheevos)
2: I'm a mobile user, so I'm not aware of most libretro cores outside of the ones offered on Android (OS in which I use RetroArch)

@SuperGamer18 SuperGamer18 deleted the patch-1 branch July 31, 2024 21:17
@wescopeland
Copy link
Member

@SuperGamer18 Not sure what happened - I was tied up with work and wasn't able to give final approval. If you'd like to reopen the PR I'm happy to walk through getting it merged.

@SuperGamer18
Copy link
Contributor Author

SuperGamer18 commented Jul 31, 2024

Damn, just as I was fixing the Spanish translation. Oh well, guess I'll take my time to improve the English version even further and update the Spanish version to be on par with the former. BTW should I have both in the same PR or should I open separate PRs for each language?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants