Expand apostrophe section in writing-policy.md #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites the apostrophe section to be more inclusive of when apostrophes are used (and not used) in English. The previous version is worded a little strangely in places and doesn't mention the (in my view) most common error, which is using apostrophes with plurals. I didn't want to change any subjective policy here, but I think, if you want this to be part of the policy, adding a note that contractions should generally be avoided would not be out of place here. That's a pretty common guideline for formal writing. But for the sake of this PR I just wanted to keep it to objective English grammar stuff. Apologies that I've been bugging you with this section lately, with me editing the wiki, then that had to get reverted, then I dm'd the QA team with a now-broken link... This should be the last you hear of it from me!
|
PR adds useful delineation of case. Recommend approval. |
wescopeland
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the apostrophe section to be more inclusive of when apostrophes are used (and not used) in English. The previous version is worded a little strangely in places and doesn't mention the (in my view) most common error, which is using apostrophes with plurals.
I didn't want to change any subjective policy here, but I think, if you want this to be part of the policy, adding a note that contractions should generally be avoided would not be out of place here. That's a pretty common guideline for formal writing. But for the sake of this PR I just wanted to keep it to objective English grammar stuff.
Apologies that I've been bugging you with this section lately, with me editing the wiki, then that had to get reverted, then I dm'd the QA team with a now-broken link... This should be the last you hear of it from me!