Fix bug 47 handle html responses #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
filipenasc
reviewed
Aug 22, 2019
lib/rdstation/error_handler.rb
Outdated
| @@ -13,6 +13,8 @@ def raise_error | |||
| raise error_class, array_of_errors.first if error_class < RDStation::Error | |||
|
|
|||
| error_class.new(array_of_errors).raise_error | |||
| rescue JSON::ParserError => error | |||
| raise error_class, {'error_message' => response.body} | |||
There was a problem hiding this comment.
Missing spaces around the curly braces: { 'error_message' => response.body }
There was a problem hiding this comment.
Instala o linter-rubocop nesse Atom aí! :D
| @@ -13,6 +13,8 @@ def raise_error | |||
| raise error_class, array_of_errors.first if error_class < RDStation::Error | |||
|
|
|||
| error_class.new(array_of_errors).raise_error | |||
| rescue JSON::ParserError => error | |||
There was a problem hiding this comment.
Since we are handling this error directly in the API response, in which cases that exception would be raised?
There was a problem hiding this comment.
this will be raised when the body ain't a valid JSON. The most comon scenario for this to happen is when we have a downtime on the API.
Seralto
approved these changes
Sep 3, 2019
Seralto
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #47
In case of an HTML response by the API (which can happen when there is a major outage) the client was trying to parse a HTML as JSON, which resulted in raising
JSON::ParserError. This made it impossible to know what the actual error is.The proposed change here is to encapsulate the parse error and raise the correct exception, with the whole html body as the error message.