Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logo of the matrix was without the attribute alt. #357

Merged

Conversation

silvanavlima
Copy link
Member

Description

It is an important attribute used specifies an alternate text for an image that cannot be displayed.
The project has the option switch language, so I took advantage of the opportunity to add the option at alt in English/Portuguese.

How to test?

Switch language and logo inspect.

Expected behavior

Check down:
Version En
Version PT-BR

angeliski
angeliski previously approved these changes Oct 3, 2020
Copy link
Contributor

@angeliski angeliski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angeliski angeliski changed the base branch from master to develop October 3, 2020 13:20
@angeliski angeliski dismissed their stale review October 3, 2020 13:20

The base branch was changed.

@angeliski
Copy link
Contributor

Hey @silvanavlima, Thanks for your contribution!
Can you make a rebase based in develop branch?

Copy link
Contributor

@juliemar juliemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats 🚀 LGTM

@juliemar juliemar merged commit 1898a8d into ResultadosDigitais:develop Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The logo of the matrix was without the alt attribute.
3 participants