-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(office): fixes user invitation to external meeting opening jitsi instead #331
fix(office): fixes user invitation to external meeting opening jitsi instead #331
Conversation
I decided to take the shortest path to fix this one since it is something my company needs to use. I extracted the I think that function should be extracted to another file instead of |
Nice @phiter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent refactoring! This division by functions was very good. 💯 🚀
Would you mind doing some tests to ensure this behavior?
I left a comment regarding the signature of a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @phiter I just merged your previous PR and now there is a conflict in this branch. Could you fix them for me to continue merge?
@juliemar done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Description
This fixes a bug where when inviting users to join an external meeting, a jitsi room was created instead.
closes #222
How to test?
Expected behavior
The user should join the external meeting and no jitsi call should be created for that room.