Adds possibility to migrate feature_keys to resource_keys #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayvsonlima
reviewed
Jul 13, 2020
Why? As detected in code review, we didn't cover one critical path of the migration with tests.
dayvsonlima
reviewed
Jul 31, 2020
| end | ||
|
|
||
| it 'does not migrate internal keys' do | ||
| expect(redis.keys.count).to eq(7) |
dayvsonlima
previously approved these changes
Jul 31, 2020
andrehjr
reviewed
Aug 3, 2020
dayvsonlima
previously approved these changes
Aug 3, 2020
andrehjr
previously approved these changes
Aug 3, 2020
ff5c27c to
6d3f2fd
Compare
|
Code Climate has analyzed commit 6d3f2fd and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 98.5% (80% is the threshold). This pull request will bring the total coverage in the repository to 99.0% (0.0% change). View more on Code Climate. |
andrehjr
approved these changes
Aug 3, 2020
dayvsonlima
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a rake task to perform synchronization between feature_keys (keys that hold information about which resources were released to a given feature) and resource_keys (keys that hold information about which features were released to a given resource).