Optimize scoring vector tiles #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c7f9d2 to
65f374a
Compare
|
Oh, I wasn't paying attention to CI. I'll push a fix for those |
f37ac13 to
2621b3d
Compare
This removes the expensive `color_code` subquery and adds a new endpoint that returns the color mapping by itself. The endpoint is cached, but even on cache misses it is much faster than the previous method.
2621b3d to
e027d3b
Compare
|
@BryonLewis I added a fix for the color code simple/detailed filter. Can you try this out again? |
BryonLewis
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the expensive
color_codesubquery and adds a new endpoint that returns the color mapping by itself. The endpoint is cached, but even on cache misses it is much faster than the previous method.I've updated the client to handle this new approach. This required reworking how the color_code MapLibre filter worked quite a bit.