Upgrade to django-ninja v1 / pydantic v2
#540
Conversation
248f905 to
d7408b6
Compare
This is a major upgrade that requires changes to all the Pydantic-based schemas. See https://docs.pydantic.dev/latest/migration/
d7408b6 to
262a2fa
Compare
Fields that are explicitly *optional* (i.e. can be missing entirely, as opposed to being present with a value of `None`) now need to be assigned `None` by default. See https://docs.pydantic.dev/2.9/migration/#required-optional-and-nullable-fields
See note about mode='after' on this page (CTRL-F for mode='after') https://docs.pydantic.dev/2.5/concepts/validators/#model-validators
This is required because rio-tiler v5 is incompatible with pydantic 2. Note, v7 is the latest version, but it contains a substantial number of breaking changes. To keep things simple, we can upgrade to v6 for now and revisit v7 later.
4401844 to
5dab197
Compare
|
@BryonLewis @floryst this is ready for review. I tried testing the entire feature set of the application with these changes, and I fixed all the issues I came across. But, it's very possible that I missed something considering the scope of changes, so any further stress testing of the whole system would be welcome 🙂 Also, I would suggest we postpone merging this PR until v1.14, so no particular urgency here. |
There was a problem hiding this comment.
Most things involving the endpoints touched seemed to work properly including downloading and the downloading stats.
Not approval yet but just a checklist of things I went over:
-
Scoring - image fetching and visualization for WV and S2
-
Scoring - visualization of Sites/Observations, Scoring Mode
-
Scoring - Selection of site and downloading of Animations
-
RGD - image fetching and visualization in map for WV and S2
-
RGD - Site/Observation vector tile visualization
-
RGD - Selection of objects and exporting animations
-
RGD - Downloading JSON file
Not Working:
- Image Browser in both RGD and Scoring - I think a merge to main will fix it. Forrest I believe fixed a CSS issue for this
- Scrolling the ModelRun list - I believe this again is a merge from main that will fix it.
|
Closing after discussing with @aashish24. We might revisit this in the future |
This is a major upgrade that requires changes to many of our Pydantic-based schemas. See https://docs.pydantic.dev/latest/migration/.
A lot of the changes in this PR were automated by the
bump-pydantictool, with some manual cleanup and fixes after.Note, pydantic 2 also claims backwards compatibility with pydantic 1 code via the nested
pydantic.v1package. However,django-ninjadoes not support it so we can not use it here.