Optimize sites list query #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the color_code subquery to a separate query to avoid a slow subquery in the main query, due to the EvaluationBroadAreaSearchDetection table being extremely large. The number of sites in an evaluation run is small enough that it's feasible to load the site_id->color_code mapping into memory and manually join it with the sites_list in Python.
zachmullen
approved these changes
Nov 14, 2024
BryonLewis
approved these changes
Nov 14, 2024
zachmullen
reviewed
Nov 14, 2024
| @@ -697,6 +697,7 @@ def get_sites_query(model_run_id: UUID4): | |||
| sites=JSONBAgg( | |||
| JSONObject( | |||
| id='pk', | |||
| site_id='site_id', | |||
There was a problem hiding this comment.
Is this setting this to the literal string 'site_id' or is it automatically doing F('site_id')?
There was a problem hiding this comment.
It's automatically doing F('site_id'). I thought the same thing when I saw id='pk'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the color_code subquery to a separate query to avoid a slow subquery in the main query, due to the
EvaluationBroadAreaSearchDetection table being extremely large. The number of sites in an evaluation run is small enough that it's feasible to load the site_id->color_code mapping into memory and manually join it with the sites_list in Python.