Cleaner version display format #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floryst
approved these changes
Sep 12, 2024
floryst
reviewed
Sep 12, 2024
Comment on lines
+50
to
+52
| post_num: int | None = parsed_version.post | ||
| if post_num is not None: | ||
| version += f'.post{post_num}+{parsed_version.local}' |
There was a problem hiding this comment.
What's the difference between api.version and the string constructed here?
There was a problem hiding this comment.
When the current version is not a tagged release, they differ only slightly. For example, for the latest commit on this branch
print(api.version) # prints '1.10.2.post5.dev0+b074e39c'
print(version) # prints 'v1.10.2.post5+b074e39c'The main motivation behind this change is to make it look more user friendly when the curent version is a tagged release, which looks like this
print(api.version) # prints '1.12+b074e39c'
print(version) # prints 'v1.12'b074e39 to
0cfbd79
Compare
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the version string in the UI to be more user friendly.
Tagged release versions now look like this:
And pre-release versions remain the same:
