Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ground Truth List for Simple/Detailed views #492

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

BryonLewis
Copy link
Contributor

@BryonLewis BryonLewis commented Aug 23, 2024

Previously the Site List while in scoring mode and looking at the simple or detailed views wouldn't display the ground truth in the list.

Updates:

  • Makes sure the simple/detailed scoring views don't filter out the ground truth
  • Adds to the backend the color_code data for each site. This may be an expensive operation in comparison to not having it
  • Handles filtering the sites in the list based on the simple/detailed display properties in the annotation colors
  • Adds an X/Y (x out of y) to the site list to indicate how many sites are displayed out of the total number of sites.
ScoringSiteListFix_small.mp4

@BryonLewis BryonLewis changed the title Enable Ground Truth Lsit for Simple/Detailed views Enable Ground Truth List for Simple/Detailed views Aug 27, 2024
Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com>
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the video explanation, that helped clarify this. I imagine the performance bottleneck is still the vector tile generation itself, so I think having the new subquery for color code isn't too bad.

@BryonLewis BryonLewis merged commit c8c2c2b into main Aug 28, 2024
9 checks passed
@BryonLewis BryonLewis deleted the scoring-site-list branch August 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants