Fix downloading UI #456
Merged
Fix downloading UI #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
reviewed
Aug 9, 2024
rdwatch/scoring/views/model_run.py
Outdated
| @@ -507,11 +507,9 @@ def list_model_runs( | |||
| @router.get('/{id}/', response={200: ModelRunDetailSchema}) | |||
| def get_model_run(request: HttpRequest, id: UUID4): | |||
| try: | |||
| EvaluationRun.objects.get(pk=id) | |||
| data = get_queryset() | |||
| data = get_object_or_404(get_queryset(), id=id) | |||
There was a problem hiding this comment.
I don't think get_object_or_404 raises EvaluationRun.DoesNotExist here, so wouldn't this fail prematurely?
There was a problem hiding this comment.
Thanks for finding that, you're correct. This won't properly swap to the proposal query.
There was a problem hiding this comment.
Decided to give a more descriptive error with missing EvaluationRun/AnnotationProposalSet.
mvandenburgh
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #431