Add TIA V18-19 and ability to read InstanceOf property for PLC Block. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Have you tested this with v18? Im asking this because you are also changing the default tia portal version to 18 but I have never tested or developed this library for that specific version. |
|
Hi!
Yep, I have tested with v18, however not with 19, but I added it in case of that it will work the same. 😅
Skickat från Outlook för Android<https://aka.ms/AAb9ysg>
…________________________________
From: Jasper Delahaije ***@***.***>
Sent: Wednesday, June 19, 2024 9:37:23 PM
To: Repsay/tia-openness-api-client ***@***.***>
Cc: Fasth, Fabian () ***@***.***>; Author ***@***.***>
Subject: Re: [Repsay/tia-openness-api-client] Add TIA V18-19 and ability to read InstanceOf property for PLC Block. (PR #5)
Looks good. Have you tested this with v18? Im asking this because you are also changing the default tia portal version to 18 but I have never tested or developed this library for that specific version.
—
Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFAZMI3MIPFZ5QXYIMF7WTDZIHMXHAVCNFSM6AAAAABJSCVGGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGM3DGNRYGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TIA V18-19 and ability to read InstanceOf property for PLC Block.