WIP Streaming the heap snapshot! #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e7042e to
4a7ebf7
Compare
This should prevent the engine from OOMing while recording the snapshot! Now we just need to sample the files, either online, before downloading, or offline after downloading :) If we're gonna do it offline, we'll want to gzip the files before downloading them. Allow custom filename; use original API Support legacy heap snapshot interface. Add reassembly function. Add tests Apply suggestions from code review Update src/gc-heap-snapshot.cpp Change to always save the parts in the same directory This way you can always recover from an OOM Fix bug in reassembler: from_node and to_node were in the wrong order Fix correctness mistake: The edges have to be reordered according to the node order. That's the whole reason this is tricky. But i'm not sure now whether the SoAs approach is actually an optimization.... It seems like we should probably prefer to inline the Edges right into the vector, rather than having to do another random lookup into the edges table? Debugging messed up edge array idxs Disable log message Write the .nodes and .edges as binary data Remove unnecessary logging
4a7ebf7 to
c4c5c00
Compare
|
This PR is stale because it has been open 30 days with no activity. Comment or remove stale label, or this PR will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Streaming the heap snapshot!
This should prevent the engine from OOMing while recording the snapshot!
Now we just need to sample the files, either online, before downloading, or offline after downloading :)
If we're gonna do it offline, we'll want to gzip the files before downloading them.
Checklist
Requirements for merging:
port-to-*labels that don't apply.