enable safepoint straggler bt printing unconditionally #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpamnany
reviewed
Feb 28, 2025
There was a problem hiding this comment.
As discussed, I suggest merging and backporting JuliaLang#57579 first, then confirming that this works as intended before we merge it.
…gler (JuliaLang#57579) In the line of C code: ```C const int64_t timeout = jl_options.timeout_for_safepoint_straggler_s * 1000000000; ``` `jl_options.timeout_for_safepoint_straggler_s` is an `int16_t` and `1000000000` is an `int32_t`. The result of `jl_options.timeout_for_safepoint_straggler_s * 1000000000` will be an `int32_t` which may not be large enough to hold the value of `jl_options.timeout_for_safepoint_straggler_s` after converting to nanoseconds, leading to overflow.
911ced5 to
d61ad42
Compare
|
I'd like to keep both commits in a single PR, and then, when it's time to merge we "rebase and merge" (as opposed to "squash and merge"). Anyway, this seems to work: ./julia -t8
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _` | |
| | |_| | | | (_| | | Version 1.10.2+RAI (2025-03-02)
_/ |\__'_|_|_|\__'_| | dcn-enable-safepoint-straggler-unconditionally/d61ad42b07 (fork: 429 commits, 608 days)
|__/ |
julia> function main()
t = Threads.@spawn begin
ccall(:uv_sleep, Cvoid, (Cuint,), 70_000)
end
# Force a GC
ccall(:uv_sleep, Cvoid, (Cuint,), 10_000)
GC.gc()
wait(t)
end
main (generic function with 1 method)
julia> main()
===== Thread 2 failed to reach safepoint after 60 seconds, printing backtrace below =====
thread (1) __semwait_signal at /usr/lib/system/libsystem_kernel.dylib (unknown line) |
vustef
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Let's enable the safepoint straggler bt printing unconditionally.
Checklist
Requirements for merging:
port-to-*labels that don't apply.