CMake: Bump minimum version to 3.2 #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer cmake issues a warning when required version is < 3. Version 3.2 should be old enough (eg ubuntu 16.04 has version 3.5).
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 83.23% 83.23%
=======================================
Files 1820 1820
Lines 170835 170835
=======================================
Hits 142195 142195
Misses 28640 28640 Continue to review full report at Codecov.
|
|
good to go @langou ? |
|
Thanks for pinging me on this. Yes, this sounds great to me. Thanks. |
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
CMake: Bump minimum version to 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer cmake issues a warning when required version is < 3.
Version 3.2 should be old enough (eg ubuntu 16.04 has version 3.5).