Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataImportCron tests based on wrapper fixes #157

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix DataImportCron tests based on wrapper fixes #157

merged 1 commit into from
Jan 21, 2025

Conversation

geetikakay
Copy link
Contributor

Short description:

Due to changes in wrapper, we introduce this patch

More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:

@geetikakay
Copy link
Contributor Author

/wip

@cnv-qe-bot1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
  • to assign reviewer to PR use /assign-reviewer @<reviewer>
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest build-container: Retest build-container
  • /retest all: Retest all
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@cnv-qe-bot1 cnv-qe-bot1 mentioned this pull request Jan 20, 2025
Closed
@redhat-cnv-qe-bot1 redhat-cnv-qe-bot1 changed the title Fix DataImportCron tests based on wrapper fixes WIP: Fix DataImportCron tests based on wrapper fixes Jan 20, 2025
@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-tc-requirement-polarion started: cnv-tests-tox-executor/5727

@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-bugs-are-open started: cnv-tests-tox-executor/5728

polarion-jenkins
polarion-jenkins previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@polarion-jenkins polarion-jenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D/S test tox -e verify-bugs-are-open passed: cnv-tests-tox-executor/5728

@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-tc-requirement-polarion started: cnv-tests-tox-executor/5729

@geetikakay
Fix DataImportCron tests based on wrapper fixes
ebe27a2 
Signed-off-by: Geetika Kapoor <gkapoor@redhat.com>
@geetikakay
Copy link
Contributor Author

geetikakay commented Jan 21, 2025 •
edited
Loading

/verified
tried locally

polarion-jenkins
polarion-jenkins approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@polarion-jenkins polarion-jenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D/S test tox -e verify-bugs-are-open passed: cnv-tests-tox-executor/5790

@dbasunag dbasunag merged commit dff461f into RedHatQE:main Jan 21, 2025
6 checks passed
@redhat-cnv-qe-bot
Copy link

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-157.

@redhat-cnv-qe-bot
Copy link

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarion-jenkins polarion-jenkins polarion-jenkins approved these changes

@hmeir hmeir hmeir approved these changes

@jpeimer jpeimer jpeimer approved these changes

@dbasunag dbasunag dbasunag approved these changes

@RoniKishner RoniKishner Awaiting requested review from RoniKishner

@duyanyan duyanyan Awaiting requested review from duyanyan

@vsibirsk vsibirsk Awaiting requested review from vsibirsk

@dshchedr dshchedr Awaiting requested review from dshchedr

Assignees
No one assigned
Labels
approved-dbasunag approved-jpeimer branch-main can-be-merged lgtm-hmeir lgtm-polarion-jenkins size/M tox:verify-bugs-are-open:passed D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@geetikakay @cnv-qe-bot1 @polarion-jenkins @redhat-cnv-qe-bot @jpeimer @dbasunag @hmeir @redhat-cnv-qe-bot1