Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull method created data import cron #118

Merged

Conversation

RoniKishner
Copy link
Contributor

@RoniKishner RoniKishner commented Jan 14, 2025

Short description:

Change the method we used to create a new data import cron

More details:

Changed the way the data import cron is created to deploy the resource from a complete new object

What this PR does / why we need it:

Latest DataImportCron object added required resource on pull_method, which is blocking the creation of the current resource.

In addition since it is not a required resource, created a PR for the wrapper we use - RedHatQE/openshift-python-wrapper#2280

Which issue(s) this PR fixes:

Failing test class TestDataImportCronDefaultStorageClass

@redhat-cnv-qe-bot
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
  • to assign reviewer to PR use /assign-reviewer @<reviewer>
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest build-container: Retest build-container
  • /retest all: Retest all
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-bugs-are-open started: cnv-tests-tox-executor/5483

@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-tc-requirement-polarion started: cnv-tests-tox-executor/5482

@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-bugs-are-open started: cnv-tests-tox-executor/5485

@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-tc-requirement-polarion started: cnv-tests-tox-executor/5484

Copy link
Collaborator

@polarion-jenkins polarion-jenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D/S test tox -e verify-bugs-are-open passed: cnv-tests-tox-executor/5485

@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-tc-requirement-polarion started: cnv-tests-tox-executor/5543

@polarion-jenkins
Copy link
Collaborator

D/S test tox -e verify-bugs-are-open started: cnv-tests-tox-executor/5544

Copy link
Collaborator

@polarion-jenkins polarion-jenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D/S test tox -e verify-bugs-are-open passed: cnv-tests-tox-executor/5544

@dbasunag
Copy link
Collaborator

/verified

@dbasunag
Copy link
Collaborator

/check-can-merge

@dbasunag dbasunag merged commit d012c15 into RedHatQE:main Jan 15, 2025
6 checks passed
@redhat-cnv-qe-bot1
Copy link

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-118.

@redhat-cnv-qe-bot1
Copy link

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants