Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gitlab search API to find repos #325

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

bsquizz
Copy link
Collaborator

@bsquizz bsquizz commented Aug 31, 2023

If there are more than 100 repos in a gitlab group, we fail to find the repo due to pagination. Thanks to @Victoremepunto for suggesting we use the search API instead.

We could potentially get over 100 results from a search, but it is highly unlikely. We can deal with the pagination at that time if it happens.

@Victoremepunto Victoremepunto self-requested a review August 31, 2023 15:02
Copy link
Collaborator

@Victoremepunto Victoremepunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsquizz bsquizz merged commit 3d9e2bc into master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants