Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unleash proxy to frontend dependencies #313

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

maknop
Copy link
Collaborator

@maknop maknop commented Jul 7, 2023

No description provided.

@bsquizz
Copy link
Collaborator

bsquizz commented Jul 7, 2023

Is this different from the featureflags service that Clowder spins up in ephemeral namespaces?

@maknop
Copy link
Collaborator Author

maknop commented Jul 17, 2023

Is this different from the featureflags service that Clowder spins up in ephemeral namespaces?

Yes it is. We need the unleash proxy to access the featureflags pod in each ephemeral namespace. Currently, that featureflags pod is not accessible. This change coupled with a fix I'll open against the unleash proxy will fix the issues related to access for ephemeral namespace users. Oh, I also need to figure something out with the Ingress for the service. Currently it has the wrong route. I manually updated it in my namespace while I was trying to get something working.

I think waiting to push this change until the unleash proxy gets that patch is preferred.

Another pod to spin up in each ephemeral environment is not preferred but it does get this working for users.

@maknop maknop changed the title [WIP] Adding unleash proxy to frontend dependencies draft: Adding unleash proxy to frontend dependencies Jul 17, 2023
@maknop maknop marked this pull request as draft July 17, 2023 21:20
@maknop maknop changed the title draft: Adding unleash proxy to frontend dependencies [WIP] Adding unleash proxy to frontend dependencies Jul 17, 2023
@maknop maknop self-assigned this Jul 17, 2023
@maknop maknop marked this pull request as ready for review July 18, 2023 16:33
@maknop maknop changed the title [WIP] Adding unleash proxy to frontend dependencies Adding unleash proxy to frontend dependencies Jul 18, 2023
@maknop maknop requested a review from bsquizz July 18, 2023 16:35
@bsquizz bsquizz merged commit b976754 into master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants