Publish refactor #652
Merged
Publish refactor #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a single Subjec to restore the RxJS 4 behavior that produces an Observable that cannot be retried or repeated. BREAKING: observables produced by can no longer be retried or replayed related #453
BREAKING: publishBehavior no longer produces an Observable that can be retried or repeated related #453
BREAKING: publishReplay will no longer produce an Observable that can be retried or repeated related #453
moves share to use its own call to multicast under the hood related #453
BREAKING: shareBehavior and shareReplay are no longer operators on Observable closes #453
|
Looks all OK. |
|
Great. Putting this to bed. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #453
multicastpolymorphic to support new factory behavior and old subject argument behaviorpublish,publishBehavior,publishReplaysharereturns an Observable that can be retriedshareBehaviorandshareReplayto prevent end-user-developer confusion.