Marble tests for mergeMap and unsubscription marbles for TestScheduler #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 30, 2015 13:58
Replicates most tests from RxJS 4 flatMap.
Addresses issue ReactiveX#402
Using the new unsubscription marble diagram feature in expectObservable to cover more unsubscribe-related tests from RxJS 4.
This was referenced Sep 30, 2015
| } | ||
| destination.next(innerValue); | ||
| } |
There was a problem hiding this comment.
This above wasn't just a refactor, I recall solving one of the tests failing by including this else, because otherwise there would be two calls to destination.next().
|
Overall this looks good. One thing that is interesting, is it doesn't cover the expectations of unsubscription does it? It only covers the unsubscribe. I say that's interesting, because originally my concern was the inability to examine when an inner observable was unsubscribed from, in say, switch or the like. So I guess we still have an unresolved issue. |
|
I'm going to merge this one and create a new issue. |
|
Yeah that crossed my mind. Gotta think about it. |
|
merged with 4d973a3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #402 and #374.
All tests from RxJS 4 are present in this PR, except for one test: see #422.