-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(publish): nightly publish script #3159
Conversation
Just do something like |
Although, I'm not sure I want to junk up the npm versioning with 365 builds a year... Maybe the same version every time would be better? It's worth researching the best approach. |
: makes sense. Maybe we can define one version only and stick for nightly. |
2075ca5
to
6328ead
Compare
Now PR doesn't modify but publish with |
6328ead
to
78400da
Compare
and we can actually turn this into general publish script for tagged, regular build as well 🤔 let's proceed separately, once after we verify nightly actually works. |
Marking as blocked until getting conclusion for version number strategy. |
With TypeScript, the maintainers use a concatenated year, month and day:
If it's a nightly, using a date-derived number has the additional advantage of allowing devs to quickly see how old/recent the nightly is. |
http://blog.npmjs.org/post/77758351673/no-more-npm-publish-f |
Yeah, that was my initial take. @benlesh 's primary concern is stacking up new pkgs per each day afaik. |
Sorry, I thought the plan was to always tag with nightly. ... my concern was over how to add versions if needed... like 5.5.0-nightly.SHA_HERE or something... and will that junk up the npm info for the project? That's what I was trying to figure out from @seldo on Twitter. |
I just did |
Meh. Whatever. Let's do it. @kwonoj can you fix Travis? |
Assigning myself for further. I'll try to make dry run and will ask reviwew once again before actually push the button. |
@kwonoj what are we thinking about this PR at this point? It's high on my priority list to get nightlies published. |
Just chatted with @kwonoj, and we're going to kill this one for now. |
Description:
THIS SCRIPT DOESN'T PUBLISH ANYTHING YET
I've promised this for a while, and finally able to stab at very initial steps for this.
This PR works on our travis cron job runs daily on master, replaces version in package.json into specific nightly scheme and publish it.
Since travis doesn't have npm auth token yet, all of this script is safe at this moment and does not publish anything - before start publish, need to conclude couple of things
: using
--tag=nightly
as suggestednpm publish
underdist/package
)Related issue (if exists):
#3008