Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(publish): nightly publish script #3159

Closed
wants to merge 3 commits into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Dec 4, 2017

Description:

THIS SCRIPT DOESN'T PUBLISH ANYTHING YET
I've promised this for a while, and finally able to stab at very initial steps for this.
This PR works on our travis cron job runs daily on master, replaces version in package.json into specific nightly scheme and publish it.

Since travis doesn't have npm auth token yet, all of this script is safe at this moment and does not publish anything - before start publish, need to conclude couple of things

  • what's semver safe version scheme for nightly?
    : using --tag=nightly as suggested
  • is publish script in here is correct? (run npm publish under dist/package)

Related issue (if exists):
#3008

@kwonoj kwonoj requested a review from benlesh December 4, 2017 19:26
@benlesh
Copy link
Member

benlesh commented Dec 4, 2017

what's semver safe version scheme for nightly?

Just do something like 5.5.0-nightly.COMMIT_SHA_HERE That should be fine. And make sure it's tagged with nightly.

@benlesh
Copy link
Member

benlesh commented Dec 4, 2017

Although, I'm not sure I want to junk up the npm versioning with 365 builds a year... Maybe the same version every time would be better?

It's worth researching the best approach.

@kwonoj
Copy link
Member Author

kwonoj commented Dec 4, 2017

@benlesh

  1. shouldn't it be 6.0-nightly? this is intended for master.
  2. are you referring creating git tags, or other else?

I'm not sure I want to junk up the npm versioning with 365 builds a year... Maybe the same version every time would be better?

: makes sense. Maybe we can define one version only and stick for nightly.

@kwonoj
Copy link
Member Author

kwonoj commented Dec 4, 2017

Now PR doesn't modify but publish with --tag=nightly as suggested.

@kwonoj
Copy link
Member Author

kwonoj commented Dec 4, 2017

and we can actually turn this into general publish script for tagged, regular build as well 🤔 let's proceed separately, once after we verify nightly actually works.

@kwonoj
Copy link
Member Author

kwonoj commented Dec 5, 2017

Marking as blocked until getting conclusion for version number strategy.

@cartant
Copy link
Collaborator

cartant commented Dec 5, 2017

With TypeScript, the maintainers use a concatenated year, month and day:

$ npm dist-tag ls typescript
beta: 2.0.0
insiders: 2.6.2-insiders.20171120
latest: 2.6.2
next: 2.7.0-dev.20171203
rc: 2.6.0-rc

If it's a nightly, using a date-derived number has the additional advantage of allowing devs to quickly see how old/recent the nightly is.

@cartant
Copy link
Collaborator

cartant commented Dec 5, 2017

Maybe we can define one version only and stick for nightly.

http://blog.npmjs.org/post/77758351673/no-more-npm-publish-f

@kwonoj
Copy link
Member Author

kwonoj commented Dec 5, 2017

With TypeScript, the maintainers use a concatenated year, month and day:

Yeah, that was my initial take. @benlesh 's primary concern is stacking up new pkgs per each day afaik.

@benlesh
Copy link
Member

benlesh commented Dec 5, 2017

Sorry, I thought the plan was to always tag with nightly. ... my concern was over how to add versions if needed... like 5.5.0-nightly.SHA_HERE or something... and will that junk up the npm info for the project? That's what I was trying to figure out from @seldo on Twitter.

@kwonoj
Copy link
Member Author

kwonoj commented Dec 5, 2017

I just did npm info typescript for checking how they does, and it is indeeded stacking up whole 😅 I haven't feel this is concern (probably me didn't use npm info at all) - what's main issue if it happens?

@benlesh
Copy link
Member

benlesh commented Jan 23, 2018

Meh. Whatever. Let's do it.

@kwonoj can you fix Travis?

@kwonoj kwonoj self-assigned this Jan 23, 2018
@kwonoj
Copy link
Member Author

kwonoj commented Jan 23, 2018

Assigning myself for further. I'll try to make dry run and will ask reviwew once again before actually push the button.

@benlesh
Copy link
Member

benlesh commented May 4, 2018

@kwonoj what are we thinking about this PR at this point? It's high on my priority list to get nightlies published.

@benlesh
Copy link
Member

benlesh commented Jul 26, 2018

Just chatted with @kwonoj, and we're going to kill this one for now.

@benlesh benlesh closed this Jul 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2018
@kwonoj kwonoj deleted the publish-nightly branch October 4, 2019 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants