Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the "input" event's plucking, event.target.value=> event.data #3120

Closed
wants to merge 1 commit into from

Conversation

liuyunwei
Copy link

Description:
update the tutorials to make work as expected
Related issue (if exists):
#3069

@rxjs-bot
Copy link

Warnings
⚠️

commit message does not follows conventional change log (1)

Messages
📖

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

CJS: 1377.9KB, global: 747.4KB (gzipped: 119.7KB), min: 145.2KB (gzipped: 31.3KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage remained the same at 97.078% when pulling 69f7aa8 on liuyunwei:master into cd9626a on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Jan 23, 2018

I think the original example does a better job showing that you can "deep pluck". I don't think we're going to merge this one.

Thank you very much, @liuyunwei, I greatly appreciate the thought and effort. Apologies for the slow response, and sorry we can't merge this request. I sincerely hope you contribute again.

@benlesh benlesh closed this Jan 23, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants