feat(smooth): Adds the smooth() operator, the cool operator #2508
Conversation
| declare const expectObservable: typeof marbleTestingSignature.expectObservable; | ||
| declare const expectSubscriptions: typeof marbleTestingSignature.expectSubscriptions; | ||
|
|
||
| /** @test {smooth} */ |
There was a problem hiding this comment.
I don't think we need this comment.
There was a problem hiding this comment.
hmm the other tests have them. Not sure what it's for. figured it was some sort of build time thing.
There was a problem hiding this comment.
Let's just say it's critical.
|
LGTM except for one detail. |
|
|
|
Only for use in diamond shaped flows! :) |
|
Does not work in latest Safari :[ |
|
I think there may be an inconsistency in the bridge where it states "coast to coast, LA to Chicago"... Which technically is in a coast... Oh nevermind... |
|
I love software's easter egg and april fool joke. But why this operator is released as a part of default bundled operator? This is not a code comment which can removed by some minifier and imported by default. If user uses This increases the file size of application code which uses rxjs by joke code. I strongly against to ship this operator with |
|
Because it was only released in a custom April fools build. |
It is difficult to know that it's just a joke since it has been published in stable channel and has not been disabled yet in April 2nd (PST). 😫 |
…eactiveX#2508)" This reverts commit 07905e2.
|
@saneyuki Perhaps you can clarify? It wasn't published as It's going to be removed from master shortly, if that's what you mean--but just cause code is in master doesn't make it stable. 😄 It was all in good fun I don't think we broke anyone! 🎉 |
|
|
|
Come on lads, it's just a bit of craic. You would have had to explicitly
chosen to install the specific version and added the operator. It was a
joke, a few people got it and laughed. That is the beauty of open-source,
there is room for a wink and a nod. My only complaint is there was no
reference to Yacht Rock. Keep it smooth.
…On Mon, 3 Apr 2017, 18:38 Tom Crockett, ***@***.***> wrote:
***@***.*** currently shows up as the latest version in NPM, i.e.
it's what you get by default when you npm install rxjs. I trust the joke
doesn't introduce breaking changes, but it's not very professional to
release joke code that gets marked as your latest stable release.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2508 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABI5-jL8CsCpTGvUVR9YJIogYhWfacRpks5rsS6hgaJpZM4Mv-Mo>
.
|
@martinmcwhorter no, you don't have to explicitly choose that version to get it. If you type |
|
I see latest has now been bumped to |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Demo: http://jsbin.com/nibuyesofu/2/edit?html,js,output (only works in Desktop browsers. Turn your volume up)
Prior art: https://en.wikipedia.org/wiki/Smooth_Operator
This is mostly a port of this video to RxJS https://www.youtube.com/watch?v=4TYv2PhG89A
Credit: I can't remember who first came up with this. May have been @benlesh. Let's just say it was all of us.