fix(subscribeToResult): accept array-like as result #2364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Observable.from
and operators usingsubscribeToResult
both use interfaceObservableInput
for describing their input, so it follows that they should accept and work properly on the same kind of input.And yet
works as expected on array-likes, while
errors, saying that given argument is not proper observable.
Since array-likes belong to
ObservableInput
interface, I submit fix that makes operators usingsubscribeToResult
work properly with array-likes.