Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webSocket): Add binaryType to config object #2357

Merged
merged 1 commit into from
Feb 14, 2017
Merged

feat(webSocket): Add binaryType to config object #2357

merged 1 commit into from
Feb 14, 2017

Conversation

mpodlasin
Copy link
Contributor

Description
Add binaryType to websocket config object, so that it is possible to set that parameter on underlying socket before any data emits happen.

Related
Closes #2353

Add binaryType to config object, so that it is possible
to set that parameter on underlying socket before any
data emits happen.

Closes #2353
@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage increased (+0.0007%) to 97.69% when pulling 86acbd1 on Podlas29:web-socket-binary-type into 31dfc73 on ReactiveX:master.

Copy link
Member

@jayphelps jayphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🎉

@jayphelps jayphelps merged commit e8f8153 into ReactiveX:master Feb 14, 2017
@jayphelps
Copy link
Member

@Podlas29 are you on Twitter?

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants