Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(danger): update dangerfile to validate commit message #2349

Merged
merged 1 commit into from
Feb 14, 2017
Merged

chore(danger): update dangerfile to validate commit message #2349

merged 1 commit into from
Feb 14, 2017

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Feb 9, 2017 •
edited
Loading

Description:
This PR updates dangerfile to have one additional checker, to validate commit messages if it conforms conventional change log. If commits in PR does not conforms it, bot will leave messages like below to ask to update commit messages.

screenshot_1

  • maybe warn instead of fail would be sufficient?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.689% when pulling b857fad on kwonoj:chore-danger-changelog into 6ce4773 on ReactiveX:master.

@kwonoj kwonoj force-pushed the chore-danger-changelog branch from a3ad406 to 313308e Compare February 9, 2017 06:24
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.689% when pulling a3ad406 on kwonoj:chore-danger-changelog into 6ce4773 on ReactiveX:master.

@kwonoj kwonoj force-pushed the chore-danger-changelog branch 2 times, most recently from f543eea to e3b3f61 Compare February 9, 2017 06:33
@kwonoj kwonoj changed the title chore(danger): update dangerfile to validate commit message -WIP chore(danger): update dangerfile to validate commit message Feb 9, 2017
@kwonoj kwonoj force-pushed the chore-danger-changelog branch from e3b3f61 to 25d3f4a Compare February 9, 2017 06:38
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.689% when pulling e3b3f61 on kwonoj:chore-danger-changelog into 6ce4773 on ReactiveX:master.

@coveralls
Copy link

coveralls commented Feb 9, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.689% when pulling b857fad on kwonoj:chore-danger-changelog into 6ce4773 on ReactiveX:master.

@jayphelps jayphelps merged commit d23add0 into ReactiveX:master Feb 14, 2017
@kwonoj kwonoj deleted the chore-danger-changelog branch February 14, 2017 04:49
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwonoj @coveralls @jayphelps