-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel scheduled timeout work, if no longer needed #2135
Merged
+128
−82
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
9441def
fix(timeout): Cancels scheduled timeout, if no longer needed
jayphelps 9763c03
fix(timeoutWith): Cancels scheduled timeout, if no longer needed
jayphelps 6d4937f
build(npm-scripts): update debug_mocha npm script for node 6
trxcllnt a219c6c
fix(VirtualAction): Block rescheduled VirtualActions from executing t…
trxcllnt 0de6ef5
fix(timeout): Update timeout and timeoutWith to recycle their schedul…
trxcllnt b4d0605
Merge branch 'timeout' of https://github.com/jayphelps/rxjs into jayp…
trxcllnt 8513fd2
Merge pull request #3 from trxcllnt/jayphelps-timeout
jayphelps 2e2fb9d
Merge branch 'timeout' of https://github.com/jayphelps/rxjs into jayp…
trxcllnt 9c0a8c9
test(timeout): Add types to timeout and timeoutWith specs
trxcllnt b31438d
Merge branch 'timeout' into jayphelps-timeout
trxcllnt 9e16f48
Merge pull request #4 from trxcllnt/jayphelps-timeout
trxcllnt e14c7b8
Merge branch 'master' into timeout
trxcllnt cfaa876
Fix merge conflicts
trxcllnt 44ab561
Merge branch 'master' into jayphelps-timeout
trxcllnt bb8c64e
Fix timeoutWith to work with new Subscriber leak fix.
trxcllnt e29fcdb
Merge pull request #5 from trxcllnt/jayphelps-timeout
trxcllnt 119e0d4
fix(timeout-spec): fix merge conflicts
trxcllnt fc86e5e
fix(Subscription): fold ChildSubscription logic into Subscriber to pr…
trxcllnt 5a2901d
chore(publish): 5.1.1
benlesh ad27711
Ignore coverage
timruffles 24de734
fix(subscribeToResult): accept array-like as result
mpodlasin aef558e
feat(AjaxObservable) : support 'PATCH' request type
herflis 39f4009
chore(ajax.patch): Adds test for ajax.patch
jayphelps f38a27e
fix(merge): return Observable when called with single lowerCaseO
mpodlasin db72756
feat(webSocket): Add binaryType to config object
mpodlasin ad7dd69
fix(forkJoin): add type signature for single observable with selector
mpodlasin 2b66fc4
chore(danger): update dangerfile to validate commit message
kwonoj 0bbfdf2
fix(bindNodeCallback): emit undefined when callback has no success ar…
mpodlasin dc568da
fix(bindCallback): emit undefined when callback is without arguments
mpodlasin d59d733
chore(*): correctly scope disabled `max-line-length` tslint rule
gkalpak 74dd235
fix(mergeAll): introduce variant support <T, R> for mergeMap
kwonoj b1bb0ce
feat(windowTime): maxWindowSize parameter in windowTime operator
mpodlasin 42a886a
docs(ObservableInput): add ObservableInput and SubscribableOrPromise …
mpodlasin 790a469
fix(timeoutWith): update timeoutWith to work with new Subscriber leak…
trxcllnt 0f2522d
Merge pull request #6 from trxcllnt/jayphelps-timeout
trxcllnt 94bee5d
Merge branch 'master' into jayphelps-timeout
trxcllnt c9994b0
Merge pull request #7 from trxcllnt/jayphelps-timeout
trxcllnt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems unrelated although I agree with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trxcllnt I believe this is you, cool for me to remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as long as it's in a follow up PR that's fine with me. I didn't want to clutter up the PR list with internal config changes that only affect the devs working on the project, but I leave it up to your discretion