-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests asserting unsubscription chains don't break #875
Labels
help wanted
Issues we wouldn't mind assistance with.
Comments
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 4, 2015
Add test that catch() should not break unsubscription chain. For issue ReactiveX#875.
benlesh
pushed a commit
that referenced
this issue
Dec 4, 2015
Add test that catch() should not break unsubscription chain. For issue #875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 5, 2015
Add test for repeat() operator to verify that unsubscription chains are not broken when unsubscribe happens. For issue ReactiveX#875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 5, 2015
Fix repeat() operator to add its own Subscriber to the destination Subscriber, in order to avoid breaking unsubscription chains. For issue ReactiveX#875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 5, 2015
Add test for retry() operator to verify that unsubscription chains are not broken when unsubscribe happens. For issue ReactiveX#875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 5, 2015
Fix retry() operator to add its own Subscriber to the destination Subscriber, in order to avoid breaking unsubscription chains. For issue ReactiveX#875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 5, 2015
Add test for retryWhen() operator to verify that unsubscription chains are not broken when unsubscribe happens. For issue ReactiveX#875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 5, 2015
Fix retryWhen() operator to add its own Subscriber to the destination Subscriber, in order to avoid breaking unsubscription chains. For issue ReactiveX#875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 5, 2015
Add test for groupBy() operator, to verify that unsubscription chains are not broken when the observable is unsubscribed explicitly. For issue ReactiveX#875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 5, 2015
Add test for share() operator, to verify that unsubscription chains are not broken when the last subscriber unsubscribes. For issue ReactiveX#875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 6, 2015
Add test for share() operator, to verify that unsubscription chains are not broken when the last subscriber unsubscribes. For issue ReactiveX#875.
luisgabriel
added a commit
to luisgabriel/RxJS
that referenced
this issue
Dec 7, 2015
luisgabriel
added a commit
to luisgabriel/RxJS
that referenced
this issue
Dec 7, 2015
luisgabriel
added a commit
to luisgabriel/RxJS
that referenced
this issue
Dec 7, 2015
figueredo
added a commit
to figueredo/RxJS
that referenced
this issue
Dec 7, 2015
figueredo
added a commit
to figueredo/RxJS
that referenced
this issue
Dec 7, 2015
figueredo
added a commit
to figueredo/RxJS
that referenced
this issue
Dec 7, 2015
figueredo
added a commit
to figueredo/RxJS
that referenced
this issue
Dec 7, 2015
figueredo
added a commit
to figueredo/RxJS
that referenced
this issue
Dec 7, 2015
This was referenced Dec 7, 2015
benlesh
pushed a commit
that referenced
this issue
Dec 8, 2015
Add test for repeat() operator to verify that unsubscription chains are not broken when unsubscribe happens. For issue #875.
benlesh
pushed a commit
that referenced
this issue
Dec 8, 2015
Fix repeat() operator to add its own Subscriber to the destination Subscriber, in order to avoid breaking unsubscription chains. For issue #875.
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 8, 2015
This was referenced Dec 8, 2015
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 8, 2015
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 8, 2015
This was referenced Dec 8, 2015
kwonoj
pushed a commit
that referenced
this issue
Dec 8, 2015
kwonoj
pushed a commit
that referenced
this issue
Dec 8, 2015
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 8, 2015
kwonoj
pushed a commit
that referenced
this issue
Dec 8, 2015
kwonoj
pushed a commit
that referenced
this issue
Dec 8, 2015
kwonoj
pushed a commit
that referenced
this issue
Dec 8, 2015
kwonoj
pushed a commit
that referenced
this issue
Dec 8, 2015
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 8, 2015
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 8, 2015
benlesh
pushed a commit
that referenced
this issue
Dec 8, 2015
staltz
added a commit
to staltz/RxJSNext
that referenced
this issue
Dec 8, 2015
Add test case to verify that unsubscription chains are not broken. Add test that asserts subscriptions when an unsubscription happens explicitly. Related to issue ReactiveX#875.
benlesh
pushed a commit
that referenced
this issue
Dec 8, 2015
benlesh
pushed a commit
that referenced
this issue
Dec 8, 2015
benlesh
pushed a commit
that referenced
this issue
Dec 8, 2015
benlesh
pushed a commit
that referenced
this issue
Dec 8, 2015
benlesh
pushed a commit
that referenced
this issue
Dec 9, 2015
Add test case to verify that unsubscription chains are not broken. Add test that asserts subscriptions when an unsubscription happens explicitly. Related to issue #875.
All done. Closed. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We need to add tests that each operator propagates unsubscription from the destination to the source.
Here is an example:
Notice the use of the
mergeMap
sandwich there.The text was updated successfully, but these errors were encountered: