Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: Operator ignoreElements is missing the description, and examples #4618

Closed
2 of 5 tasks
BioPhoton opened this issue Mar 6, 2019 · 2 comments
Closed
2 of 5 tasks

[docs]: Operator ignoreElements is missing the description, and examples #4618

BioPhoton opened this issue Mar 6, 2019 · 2 comments
Labels
docs Issues and PRs related to documentation help wanted Issues we wouldn't mind assistance with.

Comments

@BioPhoton
Copy link
Contributor

BioPhoton commented Mar 6, 2019 •
edited
Loading

Please check those that apply

  • typo
  • documentation doesn't exist
  • documentation needs clarification
  • error(s) in example
  • needs example

Description Of The Issue

The ignoreElements operator is missing the description.
Furthermore, there is a bug in the example. In the imports there is a typo in line 2: Rename ifnoreElements to ignoreElements
@niklas-wortmann niklas-wortmann added help wanted Issues we wouldn't mind assistance with. docs Issues and PRs related to documentation labels Mar 7, 2019
@BioPhoton BioPhoton changed the title Operator ignoreElements is missing the description, and examples [docs]: Operator ignoreElements is missing the description, and examples Mar 29, 2019
jschwarty added a commit to jschwarty/rxjs that referenced this issue Oct 14, 2019
@jschwarty
docs(ignoreElements): add description text copy
42cd6b8 
based on the ReactiveX docs for the ignoreElements operator
http://reactivex.io/documentation/operators/ignoreelements.html

ReactiveX#4618
@jschwarty jschwarty mentioned this issue Oct 14, 2019
Merged
@jschwarty
Copy link
Contributor

👋 @BioPhoton
Created a PR 😎

Looks like the typo issue was already resolved in a different commit a while ago:
3eafdcb#diff-f29a1f7a528e56b8b40ec8af2a8820c9

niklas-wortmann pushed a commit that referenced this issue Oct 19, 2019
@jschwarty @niklas-wortmann
docs(ignoreElements): add description text copy (#5074)
d372caf 
based on the ReactiveX docs for the ignoreElements operator
http://reactivex.io/documentation/operators/ignoreelements.html

#4618
@KeijiBranshi KeijiBranshi mentioned this issue May 2, 2020
Open
89 tasks
@niklas-wortmann
Copy link
Member

closed by #5074

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
docs Issues and PRs related to documentation help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jschwarty @niklas-wortmann @BioPhoton