Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iOS reference in podspec #3

Merged
merged 3 commits into from
May 10, 2015
Merged

Remove iOS reference in podspec #3

merged 3 commits into from
May 10, 2015

Conversation

orta
Copy link
Collaborator

@orta orta commented May 10, 2015

Hello there, wanted to use this in a Mac app. Opted to remove the iOS only reference. The other option is to state a version for OS X and iOS. I have no major preference.

@orta
Copy link
Collaborator Author

orta commented May 10, 2015

It also included your .tt and some module files that CocoaPods generates, so I've scoped it to only include swift files.

@kzaher
Copy link
Member

kzaher commented May 10, 2015

Hi,

this PR is really helpful, I've totally forgot about OSX target. I've only concentrated on iOS.

I'll definitely add OSX support in 1.3, should be really easy.

@orta
Copy link
Collaborator Author

orta commented May 10, 2015

👍 done

kzaher added a commit that referenced this pull request May 10, 2015
Remove iOS reference in podspec
@kzaher kzaher merged commit fa3da30 into ReactiveX:master May 10, 2015
53ningen pushed a commit to 53ningen/RxSwift that referenced this pull request Apr 6, 2016
Translates Tips documentation into Japanese
@debolee debolee mentioned this pull request Jan 6, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants