Add Completable.zip (alias for Completable.merge) #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timMorrill
approved these changes
Apr 14, 2019
|
I don't think we can do this yet. We first need to change |
|
How so? It seems the current behavior represents
|
|
The answer is here f962ddd. I've fixed it now. |
|
Oh, that's very interesting. Thanks ! |
|
@kzaher One last though on this topic - I still think it might be worth to entirely deprecate |
@freak4pc Let's deprecate it. |
This was referenced Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kzaher We've discussed this before in a different thread and I bumped into this as well, when someone asked how to do this in a Slack group.
I was actually wondering if we should just entirely remove
merge(or deprecate it) and leave onlyzip, as long as we're doing breaking changes. Sincezipbetter describes the behavior, andmergeis about merging of elements, which are not in the context of Completable.WDYT ?