Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Single trait for toArray() method #1923

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Return Single trait for toArray() method #1923

merged 3 commits into from
Apr 10, 2019

Conversation

lucas34
Copy link
Contributor

@lucas34 lucas34 commented Apr 9, 2019

No description provided.

RxSwift/Observables/ToArray.swift Outdated Show resolved Hide resolved
@freak4pc freak4pc changed the base branch from master to develop April 9, 2019 09:21
Co-Authored-By: lucas34 <7482647+lucas34@users.noreply.github.com>
RxSwift/Observables/ToArray.swift Outdated Show resolved Hide resolved
Co-Authored-By: lucas34 <7482647+lucas34@users.noreply.github.com>
@lucas34
Copy link
Contributor Author

lucas34 commented Apr 10, 2019

@freak4pc Thanks for the suggestion ! All checks passed.

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending approval from @kzaher.

@freak4pc freak4pc requested a review from kzaher April 10, 2019 07:31
@kzaher kzaher merged commit 1e759ff into ReactiveX:develop Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants