Feature/sharing operators polish #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takasek
added a commit
to takasek/RxSwift
that referenced
this pull request
Oct 12, 2017
`shareReplayLatestWhileConnected` and `shareReplay` are deprecated at ReactiveX#1430 The document comment of `SharingStrategyProtocol.share(_:)` should be fixed.
kzaher
pushed a commit
that referenced
this pull request
Oct 12, 2017
`shareReplayLatestWhileConnected` and `shareReplay` are deprecated at #1430 The document comment of `SharingStrategyProtocol.share(_:)` should be fixed.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes our sharing operators.
shareReplayLatestWhileConnectedandshareReplayin favor ofshare(replay:scope:)publish,replay,replayall to clear state in case of sequence termination to be more consistent with other Rx implementations and enable retries.sharewith default implementation ofshare(replay:scope:)so majority of operators can be derived from a single operator.